Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 new component inputSearch, now you can use the x to clean input value #416

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pauloantoniol
Copy link

@pauloantoniol pauloantoniol commented May 6, 2023

As you can see, I use a lot this page

conquista

But was annoying me, the fact that the input isn't a type search, so I made this 🥲

now you can use esc to clean the input or if you in a mobile device you can click on the X button ❤️

resultado

I really wanna this feature on the site PLEASE MERGE ME 😩 (will help me alot)

in achievement page was an input without type search, the update make a
new type of input and improve a11y
@pauloantoniol
Copy link
Author

Hey how's it going ? @MadeBaruna

I now you need to take your time, but when you have a free time, could you see this significant improvement ? 🥺
Will help me a lot if some day I could use it

input[type="search"]::-webkit-search-results-decoration {
display: none;
}
</style>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line to the bottom of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants