Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review config_check.js #3545

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

KristjanESPERANTO
Copy link
Contributor

Only details changes. No functional changes.

  • remove superfluous colors in Log.error
  • invert negative if
  • update ESLint env
  • use camel case variable name
  • optimize Log strings

- remove superfluous colors in Log.error
- invert negative if
- update ESLint env
- use camel case variable name
- optimize Log strings
@KristjanESPERANTO KristjanESPERANTO changed the base branch from master to develop September 18, 2024 19:34
@rejas rejas merged commit 06f6fbf into MagicMirrorOrg:develop Sep 18, 2024
5 of 6 checks passed
@sdetweil
Copy link
Collaborator

why is this the only acceptable answer?
Log.info(Checking config file ${configFileName} ...);

I don't like the lack of visibility of the variable use

@KristjanESPERANTO
Copy link
Contributor Author

KristjanESPERANTO commented Sep 18, 2024

why is this the only acceptable answer?

Sorry, I don't understand this question. What do you mean by answer?

I don't like the lack of visibility of the variable use

What editor do you use? I think even in editors without syntax highlighting the variables in template literals are well recognizable by the ${}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants