Make it possible to show cell updates that are newer than a setting #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn0opy
added
the
hacktoberfest-accepted
sn0opy
approved these changes
Oct 7, 2020
|
Works just fine, but I think either the sidebar option needs a proper explanation or the default value should be changed to something like 48h. It wasn't 100% clear to me what kind of changes I should expect on the map when chaning the value in the input. Changing the value in the input box doesn't trigger any changes on the map either. Not sure if we should just trigger a redraw of all the cells here. |
|
Needs better wording for sure, maybe even a little [?] with tooltip. Also should redraw on change, I didn't add it cause the whole madmin map js code is 🍝 and hard to follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pushed the rest of these code changes in by accident (and nobody seems to notice).
This PR adds a new setting in madmin map that allows users to only show cell updates that are newer than a number of milliseconds (I want to change this to minutes or hours before mergin this PR)