Enable encounters in quest mode #1186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to PD being able to hide Pokemon on the game map, it is no longer a problem that Pokemon might be clicked instead of the Pokestop during quest scan. Thus, checking for these clicks based on received encounter data is no longer necessary and encounters can be received without disturbing the quest scan flow.
Completely remove LatestReceivedType.MON from _check_for_data_content in WorkerQuests - we do not need to act on Encounter data while quest scanning anymore, it can be ignored.
|
Tested and working 👍 |
|
running sinced weeks without issues |
2022-02-21 'upstream/master' into quest-encounters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to PD being able to hide Pokemon on the game map, it is no longer a problem that Pokemon might be clicked instead of the Pokestop during quest scan.
Thus, checking for these clicks based on received encounter data is no longer necessary and encounters can be received without
disturbing the quest scan flow.
This PR enables the relevant settings
mon_ids_ivandall_monsfor pokestop areas (database change!) and changes the quest scan workflow to ignore encounter data while trying to open a pokestop.