Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need dataclasses package anymore. #1301

Open
wants to merge 1 commit into
base: async
Choose a base branch
from

Conversation

Boby360
Copy link
Contributor

@Boby360 Boby360 commented Feb 12, 2023

From what I recall, this package was only needed prior to Python 3.7.
Ran my install without the package installed with no obvious related issues.

From what I recall, this package was only needed prior to Python 3.7.
@Grennith
Copy link
Collaborator

Grennith commented Feb 25, 2023

We do use dataclasses in multiple instances afaik.
E.g., https://github.com/Map-A-Droid/MAD/blob/async/mapadroid/updater/SubJob.py#L1
Guessing it has been integrated into python natively since...
"New in version 3.7."
https://docs.python.org/3/library/dataclasses.html

@Boby360
Copy link
Contributor Author

Boby360 commented Feb 25, 2023

That is what I meant to convey.
Yes, it is integrated natively now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants