Kamila/game manger online #364

kamilababayeva · 2022-06-02T10:31:30Z

No description provided.

codeclimate · 2022-06-09T18:43:18Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        val searchByTag = LastfmMethod.BY_TAG.method
+        val searchByArtist = LastfmMethod.BY_ARTIST.method
+
+        kpop.setOnClickListener { chooseGenre(method = searchByTag, tag = "kpop", mode = R.string.kpop) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T18:43:18Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        val searchByArtist = LastfmMethod.BY_ARTIST.method
+
+        kpop.setOnClickListener { chooseGenre(method = searchByTag, tag = "kpop", mode = R.string.kpop) }
+        rock.setOnClickListener { chooseGenre(method = searchByTag, tag = "rock", mode = R.string.rock) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T18:43:18Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+
+        kpop.setOnClickListener { chooseGenre(method = searchByTag, tag = "kpop", mode = R.string.kpop) }
+        rock.setOnClickListener { chooseGenre(method = searchByTag, tag = "rock", mode = R.string.rock) }
+        bts.setOnClickListener { chooseGenre(method = searchByArtist, artist = "BTS", mode = R.string.gameGenre_bts) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T18:43:19Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        rock.setOnClickListener { chooseGenre(method = searchByTag, tag = "rock", mode = R.string.rock) }
+        bts.setOnClickListener { chooseGenre(method = searchByArtist, artist = "BTS", mode = R.string.gameGenre_bts) }
+        topTracks.setOnClickListener { chooseGenre(method = LastfmMethod.BY_CHART.method, mode = R.string.top_tracks) }
+        imagDragons.setOnClickListener{ chooseGenre(method = searchByArtist, artist = "Imagine Dragons", mode = R.string.gameGenre_imagine_dragons) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T18:43:19Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        bts.setOnClickListener { chooseGenre(method = searchByArtist, artist = "BTS", mode = R.string.gameGenre_bts) }
+        topTracks.setOnClickListener { chooseGenre(method = LastfmMethod.BY_CHART.method, mode = R.string.top_tracks) }
+        imagDragons.setOnClickListener{ chooseGenre(method = searchByArtist, artist = "Imagine Dragons", mode = R.string.gameGenre_imagine_dragons) }
+        billieEilish.setOnClickListener { chooseGenre(method = searchByArtist, artist = "Billie Eilish", mode = R.string.gameGenre_billie_eilish) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T18:58:13Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        validate.setOnClickListener{ chooseGenreByArtist(searchArtistEditable.toString(), R.string.gameGenre_byArtistSearch) }
+    }
+
+    private fun chooseGenreByTag(tag: String, mode: Int) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T18:58:13Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        chooseGenre(method = LastfmMethod.BY_TAG.method, tag = tag, mode = mode)
+    }
+
+    private fun chooseGenreByArtist(artist: String, mode: Int) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T18:58:13Z

app/src/main/java/ch/sdp/vibester/database/DataGetter.kt

+        queryRooms.addValueEventListener(object : ValueEventListener {
+            override fun onDataChange(dataSnapshot: DataSnapshot) {
+                for (score in dataSnapshot.children) {
+                    val email = (score.value as HashMap<String, Object>)["first"] as String


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T18:58:14Z

app/src/main/java/ch/sdp/vibester/database/DataGetter.kt

+            override fun onDataChange(dataSnapshot: DataSnapshot) {
+                for (score in dataSnapshot.children) {
+                    val email = (score.value as HashMap<String, Object>)["first"] as String
+                    val gameScore = ((score.value as HashMap<String, Object>)["second"] as Long).toInt()


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T19:24:07Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        val billieEilish = vmGenreSetup.view.findViewById<Button>(R.id.billieEilishButton)
+        val validate = vmGenreSetup.view.findViewById<Button>(R.id.validateSearch)
+
+        kpop.setOnClickListener { chooseGenre(tag = "kpop", mode = R.string.kpop) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T19:24:08Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        val validate = vmGenreSetup.view.findViewById<Button>(R.id.validateSearch)
+
+        kpop.setOnClickListener { chooseGenre(tag = "kpop", mode = R.string.kpop) }
+        rock.setOnClickListener { chooseGenre(tag = "rock", mode = R.string.rock) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T19:24:08Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+
+        kpop.setOnClickListener { chooseGenre(tag = "kpop", mode = R.string.kpop) }
+        rock.setOnClickListener { chooseGenre(tag = "rock", mode = R.string.rock) }
+        bts.setOnClickListener { chooseGenre(artist = "BTS", mode = R.string.gameGenre_bts) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T19:24:08Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        rock.setOnClickListener { chooseGenre(tag = "rock", mode = R.string.rock) }
+        bts.setOnClickListener { chooseGenre(artist = "BTS", mode = R.string.gameGenre_bts) }
+        topTracks.setOnClickListener { chooseGenre(mode = R.string.top_tracks) }
+        imagDragons.setOnClickListener{ chooseGenre(artist = "Imagine Dragons", mode = R.string.gameGenre_imagine_dragons) }


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2022-06-09T19:24:08Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        bts.setOnClickListener { chooseGenre(artist = "BTS", mode = R.string.gameGenre_bts) }
+        topTracks.setOnClickListener { chooseGenre(mode = R.string.top_tracks) }
+        imagDragons.setOnClickListener{ chooseGenre(artist = "Imagine Dragons", mode = R.string.gameGenre_imagine_dragons) }
+        billieEilish.setOnClickListener { chooseGenre(artist = "Billie Eilish", mode = R.string.gameGenre_billie_eilish) }


Similar blocks of code found in 5 locations. Consider refactoring.

laurislopata

👍

MaximeZmt

It might be accepted by the CI one day

codeclimate · 2022-06-09T22:34:33Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        setGenreListeners()
+
+        val bundle = this.arguments
+        if (bundle != null) {


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T22:34:33Z

app/src/main/java/ch/sdp/vibester/fragment/ChoosePartyRoomFragment.kt

+        vmChooseRoom.view = view
+        vmChooseRoom.ctx = view.context
+        val bundle = this.arguments
+        if (bundle != null) {


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T22:34:33Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+        setGameSongList(uri, playOffline)
+
+        val bundle = bundleOf("gameManager" to gameManager)
+        if(!test) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T22:34:34Z

app/src/main/java/ch/sdp/vibester/fragment/ChoosePartyRoomFragment.kt

+
+        createPartyRoom.setOnClickListener {
+            val bundle = bundleOf("gameManager" to gameManager)
+            if(!test){


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T22:34:34Z

app/src/main/java/ch/sdp/vibester/fragment/GenreSetupFragment.kt

+
+    private fun setReturnBtnListener() {
+        vmGenreSetup.view.findViewById<FloatingActionButton>(R.id.genreSetup_returnToMain).setOnClickListener {
+            if(!test) {


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-06-09T22:34:36Z

Code Climate has analyzed commit 3fc67c4 and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3
Duplication	8

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 0.0% (-84.4% change).

View more on Code Climate.

kamilababayeva and others added 30 commits June 2, 2022 10:58

bottom_navigation: add setting and genre fragments

e8f3df9

rename game setting

f238d77

rename game genre

c907adc

remove return button in game setup

610e467

create setting setup

4417851

create genre setup

1ae1b73

remove genre and setting setup from game setup

0ca55cc

add library for shared preferences

790dde1

AppPreferences: modify to set gameManager

e419163

fragment_layout_setting: setbackground

c5cc46e

fragment_layout_genre: fix settings

071c201

SettingsSetuo: receive the bundle

add050c

GenreSetupFragment: set the bundle

bda1893

GameSetup: set the controller

f25c394

tests

55e6bbd

bottom_navigation: add chooseParty fragment

973f506

rename actviity to fragment

d2304d4

rename activity to fragment

af1ee9a

gameSetupFragmentTest: fix the libraries

ed14668

fixes

6840ace

fix the naming

6a5f424

do rename

16ba048

small typos

12d97f7

MainActivity: set controller

46e24d4

trying to make navcontroller

6583e74

setup navcontroller corerctly

69ab873

AppPreferences: remove functions

a597fa1

Merge branch 'main' into kamila/gameManger_online

ab54637

Started firebase sync for custom online game

b442432

ADded firebase sync for custom online game

ab705a5

jiabaow added 4 commits June 9, 2022 20:34

refactor setGenreListeners in GenreSetupFragment.kt

abd2972

refactor setReturnBtnListener in GenreSetupFragment.kt

8ab9672

refactor getRoomData in DataGetter.kt

a976b01

refactor readScores in DataGetter.kt

c760e3e

codeclimate bot reviewed Jun 9, 2022

View reviewed changes

refactor getSnapShotValue in DataGetter.kt

9c90746

codeclimate bot reviewed Jun 9, 2022

View reviewed changes

jiabaow added 2 commits June 9, 2022 21:09

refactor chooseGenre in GenreSetupFragment.kt

2d74bd7

refactor setGenreListeners in GenreSetupFragment.kt

c54a992

codeclimate bot reviewed Jun 9, 2022

View reviewed changes

jiabaow and others added 15 commits June 9, 2022 21:28

refactor setGenreListeners in GenreSetupFragment.kt

ba896fb

downgrade mokito

df17e68

move display toast function from GameActivity.kt to Helper.kt

c363069

update dependency in build.gradle

f4bf732

fix genre test

efcec2c

MyProfileFRagment

f085788

conver findcontroller to navhostfragment

fc83d2d

comment all the tests on chooseRoomActivtiy

5bc4b2a

Commnet TypingActivity

51184bd

fix gamesetup tests

e212efd

fix GameSetupTest

d53fa2b

ChooseFragments: correct the tests

aede843

fix typing game tests

a48a633

fix tests in typing game

8f86d8b

merge main

3fc67c4

laurislopata approved these changes Jun 9, 2022

View reviewed changes

MaximeZmt approved these changes Jun 9, 2022

View reviewed changes

codeclimate bot reviewed Jun 9, 2022

View reviewed changes

Merge branch 'main' into kamila/gameManger_online

d4bf03b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kamila/game manger online #364

Kamila/game manger online #364

kamilababayeva commented Jun 2, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

laurislopata left a comment

MaximeZmt left a comment

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot Jun 9, 2022

codeclimate bot commented Jun 9, 2022

Kamila/game manger online #364

Are you sure you want to change the base?

Kamila/game manger online #364

Conversation

kamilababayeva commented Jun 2, 2022

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

laurislopata left a comment

Choose a reason for hiding this comment

MaximeZmt left a comment

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot Jun 9, 2022

Choose a reason for hiding this comment

codeclimate bot commented Jun 9, 2022