Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Expand github bot policy update comment to be more actionable #27242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

naugtur
Copy link
Contributor

@naugtur naugtur commented Sep 18, 2024

Description

Surface the need for review and docs on how to do it

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@naugtur naugtur requested a review from a team as a code owner September 18, 2024 09:44
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 18, 2024
Copy link

sonarcloud bot commented Sep 18, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [3837aea]
Page Load Metrics (1907 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23623251750505242
domContentLoaded16302315188517082
load16382329190717484
domInteractive16100532210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@naugtur naugtur added team-lavamoat and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Sep 19, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 19, 2024
@naugtur naugtur changed the title Expand github bot policy update comment to be more actionable ci: Expand github bot policy update comment to be more actionable Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-lavamoat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants