-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [POM] migrate Account Custom Name to page object model #27283
base: develop
Are you sure you want to change the base?
test: [POM] migrate Account Custom Name to page object model #27283
Conversation
…nd add descriptions
…sistent error handling
…ies for selectors
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [a1e1502]
Page Load Metrics (1873 ± 78 ms)
Bundle size diffs
|
console.log(`Opening account menu`); | ||
await this.driver.clickElement(this.accountMenuButton); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended change to remove the redundant openAccountMenu
method, we should use the one in header-navbar
.
Description
This pull request migrate account custom name interactions to page object model(POM) pattern, enhancing code maintainability, and improving test reliability. It also includes migration for the test file
test/e2e/tests/account/account-custom-name.spec.ts
as exampleRelated issues
Fixes: #27163
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist