Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #400. add warning if #cacheRepository: is set when loa… #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdebruic
Copy link
Collaborator

@pdebruic pdebruic commented Feb 5, 2019

…ding

Also fix the BaselineOf so it can load into Pharo7.

@dalehenrich
Copy link
Member

@pdebruic sorry for the delay in looking at this PR ... you've changed the baseline to allow pharo 7.0 to be loaded, however, the .travis.yml file doesn't have a pharo-7.0 test entry, so we're not getting coverage for pharo-7.0 itself?

@pdebruic
Copy link
Collaborator Author

So I missed a step? I should add pharo-7 to the travis.yml file and add that change to the PR right?

@dalehenrich
Copy link
Member

@pdebruic, yes then we can validate that the load will work ...

@dalehenrich
Copy link
Member

Looking at test results Pharo-6.1 is an expected failure for a big chunk of tests (and a big chunk of tests are failing) ... so I'm not sure that Pharo-7.0 will fare that much better, but it is worth a try I guess ... but post Pharo-6.0 all of the pharo versions are expected failures ... it may be that the iceberg mods are over-ridden by the new version of Metacello and that breaks the entire system ... I'm not sure ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants