force signature kind to toplevel #16033
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeee
reviewed
Sep 11, 2024
| @@ -1,6 +1,4 @@ | |||
| type t = Mina_signature_kind_type.t = | |||
| type t = | |||
There was a problem hiding this comment.
Let's move this type to some other Ocaml package and then remove the src/lib/signature_kind completely.
There was a problem hiding this comment.
yes that is ultimately what will happen.
src/lib/signature_lib/schnorr.ml
Outdated
| @@ -300,15 +304,15 @@ end | |||
|
|
|||
| open Snark_params | |||
|
|
|||
| module Message = struct | |||
| module Message(Context : CONTEXT) = struct | |||
There was a problem hiding this comment.
Is it necessary to parametrize the whole Message module with signature kind rather than having a ~signature_kind as a non-optional parameter to all of the functions in the module?
There was a problem hiding this comment.
I am currently experimenting with many options to get a good outcome, this will almost certainly change. It would be best to hold off on leaving comments as nothing is ready at this time
martyall
force-pushed
the
martin/force-signature_kind-to-toplevel
branch
from
25683db
to
54c35a9
Compare
martyall
force-pushed
the
martin/force-signature_kind-to-toplevel
branch
3 times, most recently
from
a0c9edd
to
15abe2f
Compare
martyall
force-pushed
the
martin/force-signature_kind-to-toplevel
branch
2 times, most recently
from
5393ee0
to
85ebde2
Compare
martyall
force-pushed
the
martin/force-signature_kind-to-toplevel
branch
from
85ebde2
to
931ea92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.