Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting and ci/cd from 2022 to 2023 versions (Sourcery refactored) #531

Open
wants to merge 1 commit into
base: where_we_are
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Aug 10, 2023

Pull Request #530 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the where_we_are branch, then run:

git fetch origin sourcery/where_we_are
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@@ -426,6 +426,7 @@ class TestModel(db.Document):
def test_modelselectfield_multiple_selected_elements_must_be_retained(app, db):
with app.test_request_context("/"):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_modelselectfield_multiple_selected_elements_must_be_retained refactored with the following changes:

@@ -497,6 +498,7 @@ class BlogPost(db.Document):
def test_embedded_model_form(app, db):
with app.test_request_context("/"):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_embedded_model_form refactored with the following changes:

Comment on lines +519 to +531

class FoodItem(db.Document):
title = db.StringField()



class FoodStore(db.Document):
title = db.StringField(max_length=120, required=True)
food_items = db.ListField(field=db.ReferenceField(document_type=FoodItem))

def food_items_label_modifier(obj):
return obj.title
def food_items_label_modifier(self):
return self.title

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_form_label_modifier refactored with the following changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants