Do DeleteByQuery in two steps #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2024 13:43
Use the the interface to break up DeleteByQuery into two steps. It first does a query that returns the documents found in the query. It then uses DeleteRequest to delete the IDs that were found from the search. In this way, registry-mgr does not really need to change.
tloubrieu-jpl
approved these changes
Jul 29, 2024
| @@ -67,6 +67,13 @@ POSSIBILITY OF SUCH DAMAGE. | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| </properties> | |||
|
|
|||
| <repositories> | |||
| <repository> | |||
| <id>Openseach Snapshots</id> | |||
There was a problem hiding this comment.
typo in opensearch. Not a big deal, obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
AOSS does not support DeleteByQuery so do a search then delete the document(s).
⚙️ Test Data and/or Report
Hand test with nothing to show.
♻️ Related Issues
#53
NASA-PDS/registry-mgr#78