Fix bug finding bundle labels in directory containing both bundles and collections #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
Where are the unit tests? |
jordanpadams
approved these changes
Aug 4, 2023
jordanpadams
changed the title
jordanpadams
changed the title
Sorry @nutjob4life but @jordanpadams closed before I could respond. They are part of the automated tests and will be titled github671 after the ticket number. The fact that the automated tests passed is indication that the unit test passed. |
|
@al-niessner thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The current implementation of the finding bundles was returning all files in the directory. Changed to only return bundles as the name of the function suggests. Previous tests did not exhibit this problem because of how they are structured - just the bundle in the directory.
⚙️ Test Data and/or Report
See unit tests below
♻️ Related Issues
Closes #671