Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functionality to throw ERROR for validation_format mismatch, and WARNING for field_format mismatch. #888

Merged
merged 10 commits into from
May 24, 2024

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented May 2, 2024

🗒️ Summary

Error when format_validation and warning when format_value.

⚙️ Test Data and/or Report

Automated unit/regression tests below passed.

#816 can be tested by the test cases for #681
#817 includes a new test case in the feature file

♻️ Related Issues

Closes #816
Closes #817

@al-niessner al-niessner requested a review from a team as a code owner May 2, 2024 21:51
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordanpadams
Copy link
Member

@al-niessner can you confirm if the tests I added checkout? I added one additional test to ensure the validation_format is actually throwing an error, versus field_format is throwing a warning.

@jordanpadams jordanpadams changed the title 816 and 817: refactor error/warn Update functionality to throw ERROR for validation_format mismatch, and WARNING for field_format mismatch. May 23, 2024
@al-niessner
Copy link
Contributor Author

@jordanpadams

Do you have a disk space issue? The errors in the latest look like not everything was pulled during the git transaction like you are running out of disk space. The failures are not code they are missing data. You can look at the logs yourself but this is the first clue (starts at line 28932 in log):

[INFO] Running cucumber.CucumberTest

Scenario Outline: Execute validate command for tests below.                                                                                                                                                                                                                                             # src/test/resources/features/developer.feature:13
  Given a test "NASA-PDS/validate#873 Success files same name different paths" at dir "github873" at resource "src/test/resources" sending report to "target/test" with "-r {reportDir}/report_github873.json -s json --skip-context-validation -R pds4.bundle -t {resourceDir}/github873" as arguments # cucumber.StepDefs.a_test_string_with_string(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
  When with test property count 0 text "0 errors expected" problem "totalErrors" reference "report_github873.json"                                                                                                                                                                                      # cucumber.StepDefs.with_test_property(int,java.lang.String,java.lang.String,java.lang.String)
  When execute a validate command                                                                                                                                                                                                                                                                       # cucumber.StepDefs.execute_a_validate_command()
  Then produced output from validate command should be similar to reference "report_github873.json" or no error reported.                                                                                                                                                                               # null

Scenario Outline: Execute validate command for tests below.                                                                                                                                                                                                                                                          # src/test/resources/features/developer.feature:16
  Given a test "NASA-PDS/validate#849 Fails inventory with duplicate entries" at dir "github849" at resource "src/test/resources" sending report to "target/test" with "-r {reportDir}/report_github849.json -s json --skip-context-validation  -t {resourceDir}/github849/collection_uvs_data_raw.xml" as arguments # cucumber.StepDefs.a_test_string_with_string(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
  When with test property count 2 text "2 errors expected" problem "INVENTORY_DUPLICATE_LIDVID" reference "report_github849.json"                                                                                                                                                                                    # cucumber.StepDefs.with_test_property(int,java.lang.String,java.lang.String,java.lang.String)
..........  When execute a validate command                                                                                                                                                                                                                                                                                    # cucumber.StepDefs.execute_a_validate_command()
  Then produced output from validate command should be similar to reference "report_github849.json" or no error reported.                                                                                                                                                                                            # null

@jordanpadams
Copy link
Member

@al-niessner 😞 I am never fixing a spelling error again. cbf6faf

@jordanpadams jordanpadams merged commit db1d3fe into main May 24, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_832.1 branch May 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants