Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duplicate file check to only check for Product Observational #914

Merged
merged 5 commits into from
May 31, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Look for the word observational in the file area and any of its ancestors.

⚙️ Test Data and/or Report

Automated unit/regression tests below should pass

♻️ Related Issues

Fixes #905

@al-niessner al-niessner self-assigned this May 30, 2024
@al-niessner al-niessner requested a review from a team as a code owner May 30, 2024 18:01
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but see my question re | vs || 😁

@jordanpadams jordanpadams changed the title 905: duplicate files only matter in observational Update duplicate file check to only check for Product Observational May 31, 2024
@jordanpadams jordanpadams merged commit 6cbd1cd into main May 31, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_905 branch May 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate 3.5.0-snapshot gives error when encountering Document objects/files used in other Document products.
3 participants