Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP2 Qualified: What gene's activity or abundance is increased by a particular chemical (Zinc, PUBCHEM.COMPOUND:23994))? #249

Closed
sstemann opened this issue Feb 6, 2023 · 4 comments
Assignees
Labels

Comments

@sstemann
Copy link
Contributor

sstemann commented Feb 6, 2023

Query: mvp2dZinc.json
PK: 72895d13-60c5-497f-a635-a702c0b4d06f

This was run on ars,ci looking for KPs and ARAs that have updated their dev environments to support qualifiers in particular for the MVP2 template query

This compound of interest was initiated by NCATS user testing of the UI for disease Phelan Mcdermid Syndrome (22q13.3 Deletion Syndrome). After reviewing results for Zinc connected to shank3, the user and Christine googled "zinc shank3" since there was no evidence on this part of the path in the UI (which is currently limited to pubmed) for MVP1. Today's standard query with qualifiers, for zinc does show connections with evidence in the Translator network (whcibut not part of MVP1 evidence Zinc-shank3).

image

@brettasmi
Copy link
Contributor

This is a true 0 results from us, and not an implementation issue.

@andrewsu
Copy link

andrewsu commented Feb 7, 2023

Apologies, this query has exposed an error in BTE's node normalization. I will edit this post later to add more details. In the mean time, this PK has perhaps more relevant results:

https://arax.ncats.io/?r=f74cf91f-3853-4961-b29e-b9966b2966a3


More notes:
The original query used PUBCHEM.COMPOUND:23994 as the input ID. Node normalizer (https://nodenormalization-sri.renci.org/1.3/get_normalized_nodes?curie=PUBCHEM.COMPOUND:23994) returns two UMLS IDs (UMLS:C0043481 and UMLS:C0795680), both of which should be used in queries by BTE. It looks like the PK posted by Sarah (72895d13-60c5-497f-a635-a702c0b4d06f) only used the latter UMLS ID. The PK I posted above is when issuing the same query using the former UMLS ID. The intended behavior is that BTE returns the union of those two PKs. I have created an issue to track the fix: biothings/biothings_explorer#560

@andrewsu
Copy link

andrewsu commented Feb 7, 2023

I misdiagnosed the behavior above as a bug in BTE. As noted by @tokebe in biothings/biothings_explorer#560 (comment), the issue was that the DEV Node Normalizer is returning the two UMLS IDs while the PROD Node Normalizer is returning one. BTE is working as expected. It's not obvious that this reflects a bug in Node Normalizer either, since probably either behavior can be justified based on different lumping/splitting criteria.

@sstemann
Copy link
Contributor Author

cannot replicate on Test or Prod

@sstemann sstemann closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants