Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: node normalization not handling case of one PubChem ID mapping to multiple UMLS IDs #560

Closed
andrewsu opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@andrewsu
Copy link
Member

andrewsu commented Feb 7, 2023

In NCATSTranslator/testing#249, the input query used PUBCHEM.COMPOUND:23994 as the input ID. Node normalizer returns two UMLS IDs (UMLS:C0043481 and UMLS:C0795680), both of which should be used in queries by BTE. It looks like the PK posted in that issue (72895d13-60c5-497f-a635-a702c0b4d06f) only used the latter UMLS ID. This PK (f74cf91f-3853-4961-b29e-b9966b2966a3) is for issuing the same query explicitly using the former UMLS ID. The intended behavior is that BTE returns the union of those two PKs.

More results examples:

@tokebe
Copy link
Member

tokebe commented Feb 7, 2023

This appears to be an issue between NodeNorms's Production and Development instances.

Querying the production server, UMLS:C0043481 is not returned.

Querying the development server, UMLS:C0043481 is returned.

BTE uses the Production server.

@andrewsu
Copy link
Member Author

andrewsu commented Feb 7, 2023

Thanks @tokebe for the more careful detective work! Closing this issue...

@andrewsu andrewsu closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants