Track $INCLUDE dependencies #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Aug 27, 2024
Comment on lines
+143
to
+144
| /* give a description here of why we maintain a "list" of file | ||
| * names */ |
There was a problem hiding this comment.
The comment seems to be todo.
| void | ||
| namedb_zone_free_filenames(namedb_type *db, zone_type* zone) | ||
| { | ||
| assert(!zone->includes.paths || !zone->filename); |
There was a problem hiding this comment.
I do not get this assertion. It seems that the zone could have a filename, and that while parsing includes.paths can get filled with include files. That makes them both not NULL and that would fail this assertion.
| VERBOSITY(3, (LOG_INFO, "zonefile %s is not modified", | ||
| fname)); | ||
| return; | ||
| } else if(zone_fname && strcmp(zone_fname, fname) >= 0 && |
There was a problem hiding this comment.
The name comparison is wrong, it seems.
Suggested change
| } else if(zone_fname && strcmp(zone_fname, fname) >= 0 && | |
| } else if(zone_fname && strcmp(zone_fname, fname) == 0 && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Fixes #57.