Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New diagnostic grids for comparing with WOA #695

Merged
merged 2 commits into from
Aug 2, 2024
Merged

New diagnostic grids for comparing with WOA #695

merged 2 commits into from
Aug 2, 2024

Conversation

adcroft
Copy link
Member

@adcroft adcroft commented Jul 26, 2024

Adds two new coordinates, designed for z*-space diagnostics:

  • WOA09INT is a more consistent set of z-level thicknesses for use with WOA09. The current WOA09 coordinate matches the WOA09 depths for most levels, but six differ by necessity. The new WOA09INT coordinate uses the depths as interface positions, so has one less level, and thus requires interpolation (mid-point averaging) of WOA09 data for direct comparison, but is more consistent.
  • WOA23INT takes the same approach as WOA09INT but uses the finer-newer WOA grid. For OM4, with a maximum depth of 6500m, WOA23INT yields 111 levels of output, instead of 34 for WOA09INT or 35 for WOA09.

@adcroft adcroft added the enhancement New feature or request label Jul 26, 2024
@adcroft adcroft requested a review from jkrasting July 26, 2024 16:05
jkrasting
jkrasting approved these changes Jul 26, 2024
View reviewed changes
Copy link

@jkrasting jkrasting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. The z_l output will be aligned at the midpoints of the WOA levels.

Hallberg-NOAA
Hallberg-NOAA approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be a valuable enhancement to the set of MOM6 diagnostic options.

@adcroft @Hallberg-NOAA
Adds new pre-defined coordinate WOA09INT
2d3866f 
In OM4, we use the "WOA09" coordinate for diagnostic z* output. This grid
was based on WOA09 but not exact because the WOA09 grid is not smooth.
We tried to construct a grid such that layer centers matched the depths
of WOA09 but this was not possible for six layers.

As an alternative, this new coordinate, "WOA09INT", uses the WOA09 depths
as interfaces so that the layer centers are always midway between the
WOA09 depths. To compare with WOA09 directly, WOA data now should be
interpolated but this is a simple half-half averaging.
@adcroft @Hallberg-NOAA
Adds new pre-defined coordinate WOA23INT
e8f3cb7 
Encoded the WOA23 depth spacing to use for finer resolution
diagnostic grid. As for WOA09INT, the WOA23 depths are used
as interface positions requiring the WOA23 data to be interpolated
(half-half averaging) to this WOA23INT grid.
@Hallberg-NOAA
Copy link
Member

This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24330, but it does have some new options listed in the MOM_parameter_doc files.

@marshallward marshallward merged commit fee3281 into NOAA-GFDL:dev/gfdl Aug 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

@jkrasting jkrasting jkrasting approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adcroft @Hallberg-NOAA @jkrasting @marshallward