fixed bug where power curve losses was shifting power curve to the le… #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft to acheive losses
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 86.98% 87.03% +0.04%
==========================================
Files 122 122
Lines 16950 16990 +40
==========================================
+ Hits 14744 14787 +43
+ Misses 2206 2203 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ppinchuk
approved these changes
Sep 6, 2023
| new_power_curve = transformation.apply(strength) | ||
| mask = new_power_curve.wind_speed >= real_power_curve.wind_speed[-10] | ||
| assert (new_power_curve[mask] == 0).all() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize('TransClass', TRANSFORMATIONS.values()) |
There was a problem hiding this comment.
That is a CLEAN test. And tests any future transformations too. Love it.
Just finished CONUS onshore+offshore runs for both Sup3rCC datasets with 0 errors or warnings, i'm encouraged! going to merge. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
fixed bug where power curve losses was shifting power curve to the le…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ft to acheive losses