Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SC column names #455

Merged
merged 88 commits into from
Jun 17, 2024
Merged

New SC column names #455

merged 88 commits into from
Jun 17, 2024

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Jun 1, 2024

All new default supply curve column updates and updated old column names to contain units and conform to standard.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 96.63526% with 25 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (0417633) to head (86480a9).

Files Patch % Lines
reV/handlers/multi_year.py 56.00% 11 Missing ⚠️
reV/supply_curve/points.py 95.45% 4 Missing ⚠️
reV/econ/economies_of_scale.py 92.85% 2 Missing ⚠️
reV/qa_qc/summary.py 0.00% 2 Missing ⚠️
reV/SAM/SAM.py 95.65% 1 Missing ⚠️
reV/bespoke/bespoke.py 98.24% 1 Missing ⚠️
reV/qa_qc/qa_qc.py 0.00% 1 Missing ⚠️
reV/supply_curve/extent.py 0.00% 1 Missing ⚠️
reV/supply_curve/supply_curve.py 98.76% 1 Missing ⚠️
tests/test_supply_curve_compute.py 98.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   87.38%   87.58%   +0.20%     
==========================================
  Files         122      122              
  Lines       17659    18062     +403     
==========================================
+ Hits        15431    15820     +389     
- Misses       2228     2242      +14     
Flag Coverage Δ
unittests 87.58% <96.63%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk marked this pull request as ready for review June 14, 2024 19:50
@ppinchuk ppinchuk merged commit ef9aa04 into main Jun 17, 2024
10 of 11 checks passed
@ppinchuk ppinchuk deleted the pp/new_column_names branch June 17, 2024 15:38
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants