Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hierarchical KV self-sufficient. #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bashimao
Copy link
Collaborator

Changes

  • Make Hierarchical KV self-sufficient.
  • Fix versions of used dependencies. Don't expect the environment to provide them.
  • Move all dependencies to third_party folder.

@github-actions
Copy link

@bashimao bashimao requested a review from rhdong May 18, 2023 12:07
@bashimao bashimao self-assigned this May 18, 2023
@bashimao bashimao added the enhancement New feature or request label May 18, 2023
@bashimao
Copy link
Collaborator Author

Long necessary change and step 1 in order to fix: #126

url = https://github.com/google/googletest.git
ignore = dirty
[submodule "third_party/libcudacxx"]
path = third_party/libcudacxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to specify the stable releases or branches. These should be the latest version of them, maybe be helpful:
https://github.com/NVIDIA/thrust/releases/tag/2.1.0
https://github.com/NVIDIA/libcudacxx/releases/tag/2.1.0

@bashimao
Copy link
Collaborator Author

Rebased to master.

@rhdong
Copy link
Member

rhdong commented May 29, 2023

/blossom-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants