Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] a standalone PR to fixup multi-defination issue across multiple… #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiashuy
Copy link
Collaborator

@jiashuy jiashuy commented Aug 21, 2024

[Fix] a standalone PR to fixup multi-defination issue across multiple source files.

@jiashuy jiashuy requested review from rhdong and Lifann August 21, 2024 12:36
@jiashuy jiashuy self-assigned this Aug 21, 2024
Copy link

@jiashuy
Copy link
Collaborator Author

jiashuy commented Aug 21, 2024

/blossom-ci

@jiashuy
Copy link
Collaborator Author

jiashuy commented Aug 21, 2024

/blossom-ci

@@ -21,15 +21,15 @@ namespace nv {
namespace merlin {
namespace group_lock {

__global__ void init_kernel(
static __global__ void init_kernel(
Copy link
Collaborator

@Lifann Lifann Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there relative issue or code snippet to reproduce the multi-definition problem?

Copy link
Collaborator

@Lifann Lifann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants