adding unit test for end-to-end example #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-669 |
bbozkaya
changed the title
day of week is between 0 and 6; it must be scaled with a max value of 6 to produce correct values from the 0-1 range. If we do col+1 and scale with 7, then a section of the 0-2pi range (for Sine purposes) will not be represented.
Reversed the previous edit for weekday scaling. It is correct that it should be scaled between 0-7, because day 0 (unused/nonapplicable after +1 added) overlaps with day 7 for Sine purposes. Monday should scale to 1/7, Sunday should scale to 7/7 to achieve even distribution of days along the sinus curve.
rnyak
approved these changes
May 12, 2023
|
rerun tests |
rnyak
changed the title
…erlin/Transformers4Rec into unittest_endtoend_multi
The `torchrun` script installed in the system is a python script with a shebang line starting with `#!/usr/bin/python3` This picks up the wrong version of python when running in a virtualenv like our tox test environment. If instead this were `#!/usr/bin/env python3` it would work ok in a tox environment to call `torchrun`. However, until either the pytorch package is updated for this to happen or we update our CI image for this to take place. Running the python command directly is more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding a unit test for end-to-end and multi-gpu training example notebook. Currently, multi-gpu notebook is broken. That's why this PR is still work-in-progress.
dependent on: #680