Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

emulate_multibleu was removed in NLTK #535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cliffwoolley
Copy link

nltk/nltk@764dc8f#diff-de624b4549ea37f3f8480d6734bd475b

Based on sgrvinod/a-PyTorch-Tutorial-to-Image-Captioning#19 (comment) it looks like emulate_multibleu is basically the default now. I verified that removing this parameter lets our CI test pass. (It does not, however, deal with backward compatibility to older NLTK; if that's required, I leave it to you all.)

@cliffwoolley cliffwoolley force-pushed the jwoolley/remove-deprecated-nltk-flag branch from bada556 to 8f040a4 Compare May 4, 2020 17:29
Copy link
Contributor

@nluehr nluehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants