-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement std::bit_cast
#2258
Merged
Merged
Implement std::bit_cast
#2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
New feature or request.
libcu++
For all items related to libcu++
labels
Aug 19, 2024
bernhardmgruber
approved these changes
Aug 19, 2024
libcudacxx/test/libcudacxx/std/numerics/bit/bit.cast/bit_cast.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/numerics/bit/bit.cast/bit_cast.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/numerics/bit/bit.cast/bit_cast.pass.cpp
Outdated
Show resolved
Hide resolved
bernhardmgruber
approved these changes
Aug 19, 2024
🟨 CI finished in 2h 12m: Pass: 97%/417 | Total: 2d 20h | Avg: 9m 54s | Max: 1h 03m | Hits: 56%/28493
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
miscco
force-pushed
the
implement_bit_cast
branch
2 times, most recently
from
August 23, 2024 11:22
6349770
to
4de3f64
Compare
🟨 CI finished in 10h 13m: Pass: 98%/417 | Total: 5d 09h | Avg: 18m 34s | Max: 1h 33m | Hits: 64%/34116
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
This backport C++20 `std::bit_cast` to be available in all standard modes. As this requires compiler builtin support, we have a non-constexpr workaround with the usual memcpy implementation. Fixes NVIDIA#2257
miscco
force-pushed
the
implement_bit_cast
branch
from
August 26, 2024 06:46
4de3f64
to
e8e7d6e
Compare
🟨 CI finished in 5h 05m: Pass: 98%/417 | Total: 6d 03h | Avg: 21m 14s | Max: 1h 14m | Hits: 14%/34188
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
miscco
commented
Aug 26, 2024
miscco
commented
Aug 26, 2024
🟨 CI finished in 10h 40m: Pass: 99%/417 | Total: 6d 05h | Avg: 21m 33s | Max: 1h 14m | Hits: 14%/34188
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
🟨 CI finished in 3h 07m: Pass: 99%/417 | Total: 3d 15h | Avg: 12m 32s | Max: 59m 55s | Hits: 71%/34188
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
🟩 CI finished in 3h 32m: Pass: 100%/417 | Total: 3d 15h | Avg: 12m 37s | Max: 59m 55s | Hits: 71%/34188
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
61 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 27, 2024
* Implement `std::bit_cast` This backport C++20 `std::bit_cast` to be available in all standard modes. As this requires compiler builtin support, we have a non-constexpr workaround with the usual memcpy implementation. Fixes NVIDIA#2257 * Add additional contraint in the fallback mode * Use bit_cast in cub * Formatting fix? * Fix typo
bernhardmgruber
pushed a commit
to bernhardmgruber/cccl
that referenced
this pull request
Aug 28, 2024
* Implement `std::bit_cast` This backport C++20 `std::bit_cast` to be available in all standard modes. As this requires compiler builtin support, we have a non-constexpr workaround with the usual memcpy implementation. Fixes NVIDIA#2257 * Add additional contraint in the fallback mode * Use bit_cast in cub * Formatting fix? * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport C++20
std::bit_cast
to be available in all standard modes.As this requires compiler builtin support, we have a non-constexpr workaround with the usual memcpy implementation.
Fixes #2257