-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a ton of lines in thrust tests #2356
Open
gonidelis
wants to merge
8
commits into
NVIDIA:main
Choose a base branch
from
gonidelis:thrust_test_init_list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 3, 2024 23:03
495fac9
to
ad33a5e
Compare
🟨 CI finished in 1h 21m: Pass: 96%/251 | Total: 1d 16h | Avg: 9m 45s | Max: 33m 16s | Hits: 97%/24375
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 251)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
miscco
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are awesome
🟨 CI finished in 1h 08m: Pass: 96%/251 | Total: 1d 12h | Avg: 8m 38s | Max: 54m 42s | Hits: 99%/24375
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 251)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟨 CI finished in 2h 56m: Pass: 96%/251 | Total: 1d 13h | Avg: 8m 51s | Max: 54m 42s | Hits: 99%/24375
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 251)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
miscco
reviewed
Sep 4, 2024
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 4, 2024 20:33
ab50fd2
to
9064c8f
Compare
bernhardmgruber
approved these changes
Sep 4, 2024
🟨 CI finished in 5h 43m: Pass: 96%/251 | Total: 1d 18h | Avg: 10m 09s | Max: 35m 43s | Hits: 97%/24375
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 251)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 5, 2024 07:44
9064c8f
to
b244e6c
Compare
bernhardmgruber
approved these changes
Sep 5, 2024
gonidelis
force-pushed
the
thrust_test_init_list
branch
2 times, most recently
from
September 5, 2024 08:17
5456f46
to
93455f3
Compare
🟨 CI finished in 1h 53m: Pass: 96%/251 | Total: 1d 09h | Avg: 8m 02s | Max: 1h 32m | Hits: 99%/24375
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 251)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 10, 2024 04:02
93455f3
to
b4ab488
Compare
gonidelis
force-pushed
the
thrust_test_init_list
branch
2 times, most recently
from
September 10, 2024 22:41
3427c58
to
aec909f
Compare
🟩 CI finished in 11h 01m: Pass: 100%/259 | Total: 1d 12h | Avg: 8m 29s | Max: 2h 04m | Hits: 99%/24441
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 259)
# | Runner |
---|---|
186 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
miscco
approved these changes
Sep 11, 2024
@gonidelis that is a fantastic cleanup 🎉 |
bernhardmgruber
approved these changes
Sep 11, 2024
gonidelis
force-pushed
the
thrust_test_init_list
branch
2 times, most recently
from
September 14, 2024 05:17
656f37b
to
4c1c924
Compare
🟨 CI finished in 1h 13m: Pass: 91%/259 | Total: 2d 08h | Avg: 13m 11s | Max: 54m 45s | Hits: 91%/17742
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 259)
# | Runner |
---|---|
186 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 14, 2024 06:50
4c1c924
to
0c751d6
Compare
🟨 CI finished in 1h 07m: Pass: 98%/259 | Total: 1d 09h | Avg: 7m 49s | Max: 28m 58s | Hits: 99%/24432
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 259)
# | Runner |
---|---|
186 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
commented
Sep 16, 2024
input[3] = 4; | ||
input[4] = 5; | ||
|
||
Vector input{1, 2, 3, 4, 5}; | ||
Vector output(5); | ||
|
||
Iterator iter = thrust::reverse_copy(input.begin(), input.end(), output.begin()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm gcc is complaining here
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 17, 2024 06:00
0c751d6
to
a30d4a2
Compare
🟨 CI finished in 5h 46m: Pass: 87%/259 | Total: 5d 16h | Avg: 31m 32s | Max: 1h 55m | Hits: 89%/17742
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 259)
# | Runner |
---|---|
186 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
force-pushed
the
thrust_test_init_list
branch
2 times, most recently
from
September 18, 2024 16:56
706688f
to
452c608
Compare
🟨 CI finished in 4h 48m: Pass: 94%/259 | Total: 1d 16h | Avg: 9m 20s | Max: 1h 39m | Hits: 99%/24432
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 259)
# | Runner |
---|---|
186 | linux-amd64-cpu16 |
42 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
gonidelis
force-pushed
the
thrust_test_init_list
branch
from
September 22, 2024 01:39
452c608
to
ad19ec5
Compare
🟨 CI finished in 1h 13m: Pass: 96%/208 | Total: 1d 18h | Avg: 12m 24s | Max: 42m 16s | Hits: 89%/11828
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 208)
# | Runner |
---|---|
171 | linux-amd64-cpu16 |
16 | linux-arm64-cpu16 |
12 | linux-amd64-gpu-v100-latest-1 |
9 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2347.
Changes the format in which we initialize inputs and assert outputs in our thrust tests using
initializer_list
and improves readability. I've all the tests undertesting/cuda
, will be adding the rest upcoming commits.Any new thrust tests should conform to that format.
ping @miscco
final diff is -2842 lines.