Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce PR testing matrix. #2436

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Reduce PR testing matrix. #2436

merged 6 commits into from
Sep 19, 2024

Conversation

alliepiper
Copy link
Collaborator

@alliepiper alliepiper commented Sep 19, 2024

  1. Temporarily remove current nightly matrix pending NVKS bringup.
  2. Move current per-PR matrix to nightly.
  3. Reduce the number of jobs in the PR matrix while maintaining decent coverage.

Before: (total jobs: 437)

Runners
320 linux-amd64-cpu16
66 linux-amd64-gpu-v100-latest-1
28 linux-arm64-cpu16
23 windows-amd64-cpu16

After (total jobs: 183)

Runners
126 linux-amd64-cpu16
26 linux-amd64-gpu-v100-latest-1
21 windows-amd64-cpu16
10 linux-arm64-cpu16

1. Temporarily remove current nightly matrix pending NVKS bringup.
2. Move current per-PR matrix to nightly.
3. Reduce the number of jobs in the PR matrix while maintaining decent coverage.

Before: (total jobs: 437)
|  320 | `linux-amd64-cpu16`
|   66 | `linux-amd64-gpu-v100-latest-1`
|   28 | `linux-arm64-cpu16`
|   23 | `windows-amd64-cpu16`

After (total jobs: 183)
|  126 | `linux-amd64-cpu16`
|   26 | `linux-amd64-gpu-v100-latest-1`
|   21 | `windows-amd64-cpu16`
|   10 | `linux-arm64-cpu16`
ci/matrix.yaml Outdated Show resolved Hide resolved
ci/matrix.yaml Outdated Show resolved Hide resolved
ci/matrix.yaml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Sep 19, 2024

Reducing linux-amd64-gpu-v100-latest-1 usage is the main consideration for me. If the additional CPU jobs provide greater confidence in build correctness, feel free to leave more of those in place. I don’t think we are contending for CPU as much as GPU.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this reduction!

@jrhemstad
Copy link
Collaborator

In the spirit of minimum viable changes for the immediate need, I'd prefer to just reduce the number of jobs that use the GPU runners and keep the build jobs unchanged.

@jrhemstad jrhemstad merged commit ee94bb9 into NVIDIA:main Sep 19, 2024
101 of 408 checks passed
@alliepiper alliepiper deleted the matrix_reorg branch September 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants