Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the sortable concept #471

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Implement the sortable concept #471

merged 1 commit into from
Sep 26, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Sep 21, 2023

Fixes #470

@miscco miscco requested review from a team as code owners September 21, 2023 12:28
@miscco miscco requested review from robertmaynard, alliepiper and ericniebler and removed request for a team September 21, 2023 12:28
@wmaxey wmaxey merged commit bfd73d3 into NVIDIA:main Sep 26, 2023
459 checks passed
elstehle pushed a commit to elstehle/cccl that referenced this pull request Nov 16, 2023
@miscco
Fix most libcxx tests (NVIDIA#471)
070697d 
* Use `__libcpp_is_unsigned_integer` for `<bit>`

* Do not use compiler builtin in tuple swap signature

* Do not try CTAD with ancient gcc

* Do not test constexpr `std::allocator` as that is not implemented

* Add missing `__pragma_pop` to `<optional>`

* Disable flaky threading tests for libcxx

* Fix `optional` libcxx tests

* Fix issues with our `construct_at` performance optimization

* Disable complex edge case test for clang

The tests runs into constexpr evaluation limits

* Disable modules tests for clang 9 and 10

* Disable invalid test where where clang has been fixed
@miscco miscco deleted the ranges_sortable branch June 17, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmaxey wmaxey wmaxey approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from NVIDIA/cccl-cmake-codeowners

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sortable concept
2 participants
@miscco @wmaxey