Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in update-ldcache hook #313

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix bug in update-ldcache hook #313

merged 1 commit into from
Jan 29, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Jan 29, 2024 •
edited
Loading

This changes fixes the default falue for the --ldconfig-path option in the nvidia-ctk update-ldconfig subcommand.

This was introduced in https://gitlab.com/nvidia/container-toolkit/container-toolkit/-/merge_requests/525

Without this containers fail with messages such as:

failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #1: error running hook: exit status 1, stdout: , stderr: time="2024-01-29T13:51:30Z" level=error msg="no such file or directory": unknown

cc @jmbaur

@elezar elezar self-assigned this Jan 29, 2024
@elezar elezar requested a review from klueska January 29, 2024 14:23
@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Jan 29, 2024
@elezar elezar mentioned this pull request Jan 29, 2024
Closed
@jmbaur
Copy link
Contributor

jmbaur commented Jan 29, 2024

Thanks @elezar!

ArangoGutierrez
ArangoGutierrez approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArangoGutierrez ArangoGutierrez merged commit 21ed60b into NVIDIA:main Jan 29, 2024
4 checks passed
@elezar elezar deleted the fix-update-ldconfig branch July 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@cdesiniotis cdesiniotis cdesiniotis approved these changes

@klueska klueska Awaiting requested review from klueska

Assignees

@elezar elezar

Labels
bug Issue/PR to expose/discuss/fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elezar @jmbaur @ArangoGutierrez @cdesiniotis