Add missing return value in divexact! methods

Also simplify a divexact method
Nemocas · Sep 20, 2024 · 507e148 · 507e148
1 parent 59d6a4f
commit 507e148
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/HeckeMoreStuff.jl b/src/HeckeMoreStuff.jl
@@ -883,6 +883,7 @@ function divexact!(A::Generic.Mat{AbsSimpleNumFieldElem}, p::ZZRingElem)
       A[i, j] = A[i, j] // p
     end
   end
+  return A
 end
 
 #

diff --git a/src/flint/fmpz_mat.jl b/src/flint/fmpz_mat.jl
@@ -555,18 +555,14 @@ function divexact(x::ZZMatrix, y::Int; check::Bool=true)
   return z
 end
 
-function divexact(x::ZZMatrix, y::ZZRingElem; check::Bool=true)
-  z = similar(x)
-  ccall((:fmpz_mat_scalar_divexact_fmpz, libflint), Nothing,
-        (Ref{ZZMatrix}, Ref{ZZMatrix}, Ref{ZZRingElem}), z, x, y)
-  return z
-end
+divexact(x::ZZMatrix, y::ZZRingElem; check::Bool=true) = divexact!(similar(x), x, y)
 
 divexact(x::ZZMatrix, y::Integer; check::Bool=true) = divexact(x, ZZRingElem(y); check=check)
 
 function divexact!(a::ZZMatrix, b::ZZMatrix, d::ZZRingElem)
   ccall((:fmpz_mat_scalar_divexact_fmpz, libflint), Nothing,
         (Ref{ZZMatrix}, Ref{ZZMatrix}, Ref{ZZRingElem}), a, b, d)
+  return a
 end
 
 ###############################################################################