Clean up HeckeMiscPoly.jl
#1853
Open
+587
−502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/miscpoly
branch
from
68b2dad
to
ed3d4f9
Compare
It is slightly more clever than the generic AbstractAlgebra method
joschmitt
force-pushed
the
js/miscpoly
branch
from
ed3d4f9
to
cef4b6a
Compare
joschmitt
force-pushed
the
js/miscpoly
branch
from
cef4b6a
to
55a34a0
Compare
joschmitt
force-pushed
the
js/miscpoly
branch
from
55a34a0
to
61365ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1853 +/- ##
==========================================
+ Coverage 86.21% 86.77% +0.55%
==========================================
Files 99 99
Lines 36030 35974 -56
==========================================
+ Hits 31064 31217 +153
+ Misses 4966 4757 -209 ☔ View full report in Codecov by Sentry. |
joschmitt
force-pushed
the
js/miscpoly
branch
from
b938a3b
to
3239fe0
Compare
joschmitt
commented
Sep 19, 2024
src/flint/fmpq_poly.jl
Outdated
Comment on lines
1027
to
1032
| function roots(R::T, f::QQPolyRingElem) where {T<:Union{fqPolyRepField, fpField}} | ||
| Rt, t = polynomial_ring(R, "t", cached=false) | ||
| fp = polynomial_ring(ZZ, cached=false)[1](f * denominator(f)) | ||
| fpp = Rt(fp) | ||
| return roots(fpp) | ||
| end |
There was a problem hiding this comment.
I'm not sure, we need this function? See the TODO comment I added for an explanation.
fingolfin
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.