Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Feature/validators external endpoint #13

Draft
wants to merge 3 commits into
base: feature/enable-prom-http
Choose a base branch
from

Conversation

aivarasko
Copy link
Contributor

Fixes | Closes | Resolves #

Anything marked as optional that you didn't need to fill in, please remove it from the PR description. Choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 96.72% // Head: 89.39% // Decreases project coverage by -7.32% ⚠️

Coverage data is based on head (e49858a) compared to base (c834299).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/enable-prom-http      #13      +/-   ##
============================================================
- Coverage                     96.72%   89.39%   -7.33%     
============================================================
  Files                            11       11              
  Lines                           488      481       -7     
============================================================
- Hits                            472      430      -42     
- Misses                           13       45      +32     
- Partials                          3        6       +3     
Flag Coverage Δ
integrationtests ?
unittests 89.39% <0.00%> (-7.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/eth2/eth2.go 94.85% <ø> (ø)
pkg/eth2/init.go 49.33% <0.00%> (-43.35%) ⬇️
pkg/eth2/networking/beacon_api.go 94.44% <0.00%> (-1.21%) ⬇️
pkg/eth2/networking/subscribe.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aivarasko aivarasko changed the base branch from main to feature/enable-prom-http October 19, 2022 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants