Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRequest-UserAgent 구현 #110

Merged
merged 1 commit into from
Sep 11, 2024
Merged

HttpRequest-UserAgent 구현 #110

merged 1 commit into from
Sep 11, 2024

Conversation

lee-ji-hoon
Copy link
Collaborator

작업 내용

Linear 막혔는데 깃헙 이슈는 뭔가 클린하게 두고 싶어서 그냥 이슈 없이 했어 ㅎㅅㅎ;

  • 백엔드에서 요청을 한 User-Agent에 유저 정보 (기기, OS 등등)을 추가하는 작업
  • 디버그 / 릴리즈 여부, OS, 기기, 언어 포함

https://discord.com/channels/1259883776474087638/1263507202329546873/1282702953417019455

체크리스트

  • 빌드 확인
  • Request에 User-Agent 잘 실려가는지 확인

동작 화면

image

살려주세요

@lee-ji-hoon lee-ji-hoon added the chore 잡일 label Sep 10, 2024
@github-actions github-actions bot requested a review from HyomK September 10, 2024 10:23
HyomK
HyomK approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@HyomK HyomK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이슈 확인했습니다 🙌

@lee-ji-hoon lee-ji-hoon merged commit 5f55744 into develop Sep 11, 2024
2 checks passed
@lee-ji-hoon lee-ji-hoon deleted the feature/request-user-agent branch September 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyomK HyomK HyomK approved these changes

Assignees

@lee-ji-hoon lee-ji-hoon

Labels
chore 잡일
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lee-ji-hoon @HyomK