Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dataset folder only when needed #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbrnaderi
Copy link

Issue I encountered

I was trying to run inference on a AWS Lambda function that has a read-only filesystem and I got an error that the dataset folder cannot be created (because the available disk was read-only). Looking at the error stack I found out that the issue is that Surprise tries to create the dataset folder even when user does not want to use the built-in datasets.

Fix

In my opinion, it is better to create the the dataset folder when it is actually needed. I have made the code change necessary for this (see that changes in this pull request). I ran all the tests in the tests folder after this change and they all pass, but please let me know if you think more tests are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant