Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atsi: init at 0.0.11 #185105

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

atsi: init at 0.0.11 #185105

wants to merge 1 commit into from

Conversation

dit7ya
Copy link
Member

@dit7ya dit7ya commented Aug 4, 2022

Description of changes

@ (atsi, "at-sign") is a tool for instantly provisioning interactive rootless Alpine containers. Think of it a little like nix-shell for Alpine.

https://github.com/queer/atsi

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, works for me 👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/899

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 11, 2023

@ofborg eval
@ofborg build atsi

description = "Instant rootless Alpine shells";
homepage = "https://github.com/queer/atsi";
license = with licenses; [ mit ];
maintainers = with maintainers; [ dit7ya ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with maintainers; [ dit7ya ];
maintainers = with maintainers; [ dit7ya ];
# unresolved imports `nix::sched::clone`, `nix::sched::CloneFlags`
broken = stdenv.isDarwin;

@@ -0,0 +1,30 @@
{ lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib
{ lib
, stdenv


src = fetchFromGitHub {
owner = "queer";
repo = pname;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo = pname; is nice for DRY but creates a binding that goes too far.

See further information about this here: nix-community/nixpkgs-lint#21

owner = "queer";
repo = pname;
rev = "0baf045c4de4862943e10d9a7bc28881f4706c71";
sha256 = "sha256-k0kD98MHN6AuX+W8VeiX6ExyaLTTZlE4/+5nQQF/x/g=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer hash = ... to sha256 = ... Both currently work, but the former will make it easier if the algorithm ever needs to change.

Since there could be different hashing algorithms in use, this make sense.


buildInputs = [ openssl ];

meta = with lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove with lib;

@drupol drupol marked this pull request as draft August 6, 2023 11:59
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants