-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atsi: init at 0.0.11 #185105
base: master
Are you sure you want to change the base?
atsi: init at 0.0.11 #185105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally, works for me 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
description = "Instant rootless Alpine shells"; | ||
homepage = "https://github.com/queer/atsi"; | ||
license = with licenses; [ mit ]; | ||
maintainers = with maintainers; [ dit7ya ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainers = with maintainers; [ dit7ya ]; | |
maintainers = with maintainers; [ dit7ya ]; | |
# unresolved imports `nix::sched::clone`, `nix::sched::CloneFlags` | |
broken = stdenv.isDarwin; |
@@ -0,0 +1,30 @@ | |||
{ lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ lib | |
{ lib | |
, stdenv |
|
||
src = fetchFromGitHub { | ||
owner = "queer"; | ||
repo = pname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo = pname;
is nice for DRY but creates a binding that goes too far.
See further information about this here: nix-community/nixpkgs-lint#21
owner = "queer"; | ||
repo = pname; | ||
rev = "0baf045c4de4862943e10d9a7bc28881f4706c71"; | ||
sha256 = "sha256-k0kD98MHN6AuX+W8VeiX6ExyaLTTZlE4/+5nQQF/x/g="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer hash = ...
to sha256 = ...
Both currently work, but the former will make it easier if the algorithm ever needs to change.
Since there could be different hashing algorithms in use, this make sense.
|
||
buildInputs = [ openssl ]; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove with lib;
Description of changes
@ (atsi, "at-sign") is a tool for instantly provisioning interactive rootless Alpine containers. Think of it a little like nix-shell for Alpine.
https://github.com/queer/atsi
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes