noseyparker: init at 0.11.0 #209415
Closed
noseyparker: init at 0.11.0 #209415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#209466 already has one approval... |
|
Meanwhile, 0.13.0 is out too. |
drupol
requested changes
Aug 6, 2023
|
|
||
| src = fetchFromGitHub { | ||
| owner = "praetorian-inc"; | ||
| repo = pname; |
There was a problem hiding this comment.
Please don't use this.
repo = pname; is nice for DRY but creates a binding that goes too far.
See further information about this here: nix-community/nixpkgs-lint#21
| owner = "praetorian-inc"; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-7hDrHYxVKduQl3kpLUHEXDPKTz1B74GjxKC5XEPYEmc="; |
There was a problem hiding this comment.
Prefer hash = ... to sha256 = ... Both currently work, but the former will make it easier if the algorithm ever needs to change.
Since there could be different hashing algorithms in use, this make sense.
| sha256 = "sha256-7hDrHYxVKduQl3kpLUHEXDPKTz1B74GjxKC5XEPYEmc="; | ||
| }; | ||
|
|
||
| cargoSha256 = "sha256-JNpTt+Oar/090FyJbUo8MYBJuXKLOIfcm6kJIIgsKyo="; |
There was a problem hiding this comment.
Suggested change
| cargoSha256 = "sha256-JNpTt+Oar/090FyJbUo8MYBJuXKLOIfcm6kJIIgsKyo="; | |
| cargoHash = "sha256-JNpTt+Oar/090FyJbUo8MYBJuXKLOIfcm6kJIIgsKyo="; |
| nativeBuildInputs = [ cmake pkg-config ]; | ||
| buildInputs = [ openssl hyperscan ]; | ||
|
|
||
| meta = with lib; { |
|
Closing as superseded by #209466. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
praetorian-inc/noseyparker: Nosey Parker is a command-line program that finds secrets and sensitive information in textual data and Git history.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes