Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beeper: init at 3.71.16 #241992

Merged
merged 1 commit into from
Aug 30, 2023
Merged

beeper: init at 3.71.16 #241992

merged 1 commit into from
Aug 30, 2023

Conversation

jshcmpbll
Copy link
Member

@jshcmpbll jshcmpbll commented Jul 7, 2023

Description of changes

adding beeper application

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@jshcmpbll
Copy link
Member Author

@jshcmpbll
Copy link
Member Author

Hitting some issues with running beeper right now:

nixos/nixpkgs git:(jc/beeper*)./result/usr/bin/beeper
[0706/172620.371544:ERROR:icu_util.cc(240)] Invalid file descriptor to ICU data received.
[1]    821388 trace trap (core dumped)  ./result/usr/bin/beeper

Open to suggestions if anyone knows more about this 😄

@bbigras
Copy link
Contributor

bbigras commented Jul 10, 2023

it seems to run with:

{ lib, mkDerivation, fetchurl, makeFontsConf, appimageTools
, qtbase, qtsvg, qtmultimedia, qtwebsockets, qtimageformats
, autoPatchelfHook, desktop-file-utils, imagemagick
, twemoji-color-font, xorg, libsodium, libopus, libGL, alsa-lib, gtk3, gnome, nss, mesa, icu }:

let
  pname = "beeper";
  version = "3.62.20";
  name = "beeper";
  nameExecutable = pname;
  src = fetchurl {
      url = "https://download.beeper.com/linux/appImage/x64";
      sha256 = "5389e24ff3cef9acc6f137d24d37e9ef319c865ef81fa3337d407f927f087e31";
      name = "${pname}-${version}.AppImage";
  };
  appimageContents = appimageTools.extractType2 { inherit name src; };
in
appimageTools.wrapType2 {
  inherit name src;

  extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs);

  meta = with lib; {
    description = "Beeper is a universal chat app. With Beeper, you can send and receive messages to friends, family and colleagues on many different chat networks.";
    homepage = "https://beeper.com";
    license = licenses.unfreeRedistributable;
    maintainers = with maintainers; [ jshcmpbll ];
    platforms = [ "x86_64-linux" ];
  };
}

I used the anytype package as a reference.

@9p4
Copy link
Contributor

9p4 commented Jul 10, 2023

https://git.sr.ht/~fd/nix-configs/tree/main/item/custompkgs/beeper

@jshcmpbll
Copy link
Member Author

@bbigras @9p4 Thank you both! I think we're ready to ship 🥳 Let me know if either of you are interested in helping maintain the package

@jshcmpbll
Copy link
Member Author

jshcmpbll commented Jul 10, 2023

App does seem to crash occasionally without much error in the busy log stream. Something to keep an eye on.

EDIT:
Adding libsecret -

nixos/nixpkgs git:(jc/beeper*)./result/bin/beeper --help
Initializing todesktop runtime
16:43:06.693 › @todesktop/runtime: AutoUpdater: Setting up UpdaterAgent
Keytar unexpected error: Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
    at process.func [as dlopen] (node:electron/js2c/asar_bundle:2:1822)
    at Module._extensions..node (node:internal/modules/cjs/loader:1326:18)
    at Object.func [as .node] (node:electron/js2c/asar_bundle:2:2049)
    at Module.load (node:internal/modules/cjs/loader:1096:32)
    at Module._load (node:internal/modules/cjs/loader:937:12)
    at f._load (node:electron/js2c/asar_bundle:2:13330)
    at Module.require (node:internal/modules/cjs/loader:1120:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/nix/store/aaq0m6k6pa5q3rawkp572i6jsihihxp6-beeper-extracted/resources/app.asar/.hak/hakModules/keytar/lib/keytar.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1241:14) {
  code: 'ERR_DLOPEN_FAILED'
}
Options:
  --profile-dir {path}: Path to where to store the profile.
  --profile {name}:     Name of alternate profile to use, allows for running multiple accounts.
  --devtools:           Install and use react-devtools and react-perf.
  --no-update:          Disable automatic updating.
  --default-frame:      Use OS-default window decorations.
  --hidden:             Start the application hidden in the system tray.
  --help:               Displays this help message.
And more such as --proxy, see:https://electronjs.org/docs/api/command-line-switches

version = "3.62.20";
src = fetchurl {
url = "${pname}-${version}.AppImage::https://download.beeper.com/linux/appImage/x64";
sha256 = "5389e24ff3cef9acc6f137d24d37e9ef319c865ef81fa3337d407f927f087e31";

This comment was marked as resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :D

@sarcasticadmin
Copy link
Member

Result of nixpkgs-review pr 241992 run on x86_64-linux 1

1 package built:
  • beeper

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Jul 11, 2023

👍 verified working for me as well, nice work @jshcmpbll !

Im added the backport label as well so this ends up in release-23.05

@jshcmpbll jshcmpbll changed the title beeper: init at 3.62.20 beeper: init at 3.64.5 Jul 14, 2023
Copy link
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #145678 which I closed for the same reason.

@jshcmpbll
Copy link
Member Author

@sumnerevans No worries, we can just point to the internet archive for now. Is there any plan to provide versioned releases at beeper?

@jshcmpbll jshcmpbll changed the title beeper: init at 3.64.5 beeper: init at 3.61.6 Jul 15, 2023
@sumnerevans
Copy link
Contributor

We have stable URLs internally, but I don't know if we have any plans to publish them. I'm not on the desktop app team.

@jshcmpbll jshcmpbll marked this pull request as ready for review August 5, 2023 20:42
@jshcmpbll jshcmpbll requested a review from drupol August 5, 2023 20:42
inherit version pname src;
};
in
mkDerivation rec {

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this comment, this cannot be applied here.

@abueide
Copy link
Contributor

abueide commented Aug 28, 2023

@9p4 @NANASHI0X74 @drupol what gpu do you guys use? I have an nvidia 3070 I'm trying to get it to run on wayland using the ozone flags but it just launches and no window shows up at all, not even the blank black screen I get without the ozone flags. If I run it using gnome x11 it works normally.

@NANASHI0X74
Copy link
Contributor

NANASHI0X74 commented Aug 28, 2023 via email

@9p4
Copy link
Contributor

9p4 commented Aug 28, 2023

I think that the integrated electron version is too old.

@abueide
Copy link
Contributor

abueide commented Aug 29, 2023

also what needs to happen for this to be merged? happy to help out however I can.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I just give a last review and made a minor comment.

Could also pass this file through nixpkgs-fmt?

nix run nixpkgs#nixpkgs-fmt -- <path-to-the-file>

version = "3.62.20";
name = "${pname}-${version}";
src = fetchurl {
url = "https://download.todesktop.com/2003241lzgn20jd/${name}.AppImage";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using this.

This creates a binding that goes too far.

See further information about this here: nix-community/nixpkgs-lint#21

Suggested change
url = "https://download.todesktop.com/2003241lzgn20jd/${name}.AppImage";
url = "https://download.todesktop.com/2003241lzgn20jd/beeper-${version}.AppImage";

@jshcmpbll jshcmpbll changed the title beeper: init at 3.61.6 beeper: init at 3.71.16 Aug 30, 2023
@jshcmpbll
Copy link
Member Author

@drupol I really appreciate the reviews! Should be all good now.

@drupol drupol merged commit 6384262 into NixOS:master Aug 30, 2023
21 of 22 checks passed
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@abueide
Copy link
Contributor

abueide commented Sep 1, 2023

I've found the stable URLs for beeper:

https://download.todesktop.com/2003241lzgn20jd/beeper-VERSION.AppImage

how did you find the URL? do you have one for mac? looking to open a PR for darwin systems.

@jshcmpbll
Copy link
Member Author

jshcmpbll commented Sep 1, 2023

@abueide Was wondering the same thing. I think I found our answers - https://github.com/beeper/todesktop-maubot/blob/696184e59f21f7b8f63b4221e57f1270ea461722/base-config.yaml#L15

https://github.com/beeper/todesktop-maubot/blob/696184e59f21f7b8f63b4221e57f1270ea461722/beeper_todesktop.py#L29

This seems to work: https://download.todesktop.com/2003241lzgn20jd/Beeper%203.74.4%20-%20Build%20230831sayxgsxpp-x64.dmg

Names a bit clunkier with spaces but I just manually downloaded the mac version and yoinked the file name from it

@9p4
Copy link
Contributor

9p4 commented Sep 1, 2023

@abueide
Copy link
Contributor

abueide commented Sep 2, 2023

hmm I just switched to the unstable channel and added the beeper package through the official nix channel but it seems to not work (I'm on x11 now).

(beeper:2): Gdk-ERROR **: 00:06:42.394: The program 'beeper' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAccess (attempt to access private resource denied)'.
  (Details: serial 273 error_code 10 request_code 130 (MIT-SHM) minor_code 1)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

@abueide
Copy link
Contributor

abueide commented Sep 2, 2023

oh weird it works now again

@sumnerevans
Copy link
Contributor

I learned that we do have stable URLs. We use todesktop, and according to https://www.todesktop.com/docs/recipes/download-links-from-your-website you can just use:

https://download.beeper.com/versions/3.77.21/linux/appImage/x64

to download the appimage for any version.

For future releases, we should utilize that.

@jshcmpbll jshcmpbll mentioned this pull request Oct 12, 2023
12 tasks
@Linux-DADDY
Copy link

beeper is broke now, Version: 3.85.17 on stable branch, and Version: 3.94.20 on unstable branch.

Here is the build result of the beeper unstable branch package

trying https://download.todesktop.com/2003241lzgn20jd/beeper-3.94.20-build-240202yjfv5ggow-x86_64.AppImage
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to download.todesktop.com port 443 after 35 ms: Couldn't connect to server
error: cannot download beeper-3.94.20-build-240202yjfv5ggow-x86_64.AppImage from any mirror
error: builder for '/nix/store/62iw4skrq68wa0s2lprwbxinqwg9r0nj-beeper-3.94.20-build-240202yjfv5ggow-x86_64.AppImage.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/yd3jx5pm5vx5i1j9jk9l12kgkjmkhxax-beeper-3.94.20-extracted.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fgik1nfaiwp43chqw8ar1sqdrz01hfxs-beeper-3.94.20-init.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3ghv28y91f13gcjhmi9b2csf9s74lvq6-beeper-3.94.20-bwrap.drv' failed to build
error: 1 dependencies of derivation '/nix/store/kqhazhgc0zy1yinmig4d5ygkdykg3jbn-beeper-3.94.20.drv' failed to build
error: 2 dependencies of derivation '/nix/store/522amzxb07jk25irsd3v071zg9rx4k4c-beeper-3.94.20.drv' failed to build
error: 1 dependencies of derivation '/nix/store/mj4q69b8zsmp9nyzgwgfh8wp7gpc6jnj-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/yda0l57cbhzh9jdsafzdwdg6qz42wz4s-X-Restart-Triggers-polkit.drv' failed to build
error: 1 dependencies of derivation '/nix/store/z3xbm0yk1hfi8g0z17dcq4m12rlngjm6-dbus-1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/5gxfsapi52dzvb7bm5akdygkkjr0awv4-unit-accounts-daemon.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/rgdn0kb5ws1fh6gb0yi4inyj7003yy4n-X-Restart-Triggers-dbus.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qj5azby6myqwk2h8y5qvd6wi91rvbv94-unit-polkit.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/p0ib9xvb8s2d3wp162fi9xy32rnmzv0f-unit-dbus.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qvdjsn991q1rxw72gvjbl7hj922diysw-unit-dbus.service.drv' failed to build
error: 3 dependencies of derivation '/nix/store/rvyz2mr83h37yh0lb6zn0a0imckhifmi-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jfz7mddllyab4f3harrbl2vy8ln7ar49-user-units.drv' failed to build
error: 4 dependencies of derivation '/nix/store/cyh76bixs6pmmf9n0vfylaawda3j8j7v-etc.drv' failed to build
error: 2 dependencies of derivation '/nix/store/k2rz324xsv76d1axpwn9iy1y67vfgms0-nixos-system-NIX_OS-23.11.4195.809cca784b9f.drv' failed to build ```

@drupol
Copy link
Contributor

drupol commented Feb 13, 2024

@jshcmpbll do you think you could help here?

@jshcmpbll
Copy link
Member Author

jshcmpbll commented Feb 13, 2024

@drupol taking a look

@Linux-DADDY First I tried checking that URL and I was able to download the app image. Maybe it was just an outage?

@mjm
Copy link
Contributor

mjm commented Feb 13, 2024

I also can't reproduce this: it's downloading fine for me. If you're still seeing issues, it might be something on your end.

@Linux-DADDY
Copy link

@mjm, @jshcmpbll, sorry, thanks for your supports, yes it was my fault, i was using a dns which is blocking that link for privacy or for protection, never thought that can happen.

@drupol
Copy link
Contributor

drupol commented Feb 13, 2024

Thanks for your fast feedback @jshcmpbll ! Glad this has been, somehow, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.