croodle: init at 0.6.2

[jboynyc]

Description of changes

Add package for the croodle web app, a privacy-respecting scheduling and polling app.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[drupol]

I think we should use the finalAttrs pattern here.

Let me share a couple of useful links regarding this:

1. History: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293
2. Documentation: https://nixos.org/manual/nixpkgs/unstable/#mkderivation-recursive-attributes
3. Recent example of implementation: https://github.com/NixOS/nixpkgs/compare/17f96f7b978e61576cfe16136eb418f74fab9952..9e6ea843e473d34d4f379b8b0d8ef0425a06defe

[jboynyc]

Do you think the derivation arguments should be moved into the attribute set as well?

[drupol]

Can you please elaborate?

[jboynyc]

Sure thing. Right now, the dataDir and debug options can be overridden because they appear in the derivation argument set:

{ lib
, fetchurl
, nixosTests
, stdenvNoCC
, writeText
, dataDir ? "/var/lib/croodle"
, debug ? false
}:

let
  configFile = ...
in
stdenvNoCC.mkDerivation (finalAttrs: { ...

If I'm understanding the finalAttrs pattern, I could also do the following:

{ lib
, fetchurl
, nixosTests
, stdenvNoCC
}:

stdenvNoCC.mkDerivation (finalAttrs: { ...
  dataDir = "/var/lib/croodle";
  debug = false;

Then I could access the values of finalAttrs.dataDir and finalAttrs.debug during the patch phase to write the configuration file. They would still be overrideable because of how the derivation wrapped in a lambda works.

Is my understanding correct and would you suggest I do so?