Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldendict-ng: init at 23.07.23 #244752

Merged
merged 2 commits into from
Aug 3, 2023
Merged

goldendict-ng: init at 23.07.23 #244752

merged 2 commits into from
Aug 3, 2023

Conversation

shenlebantongying
Copy link
Member

@shenlebantongying shenlebantongying commented Jul 22, 2023

Description of changes

Add new package https://github.com/xiaoyifang/goldendict-ng

close #239921

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !

Thanks for your contribution.

I've left some comments, left me know if this is clear enough.

Also, remember that in the end, this PR should only contains 2 commits with very specific commit messages:

  • 1 commit for adding you as maintainer: maintainers: add slbtty
  • 1 commit for the rest: goldendict-ng: init at 23.07.23

pkgs/applications/misc/goldendict-ng/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/goldendict-ng/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to select the "Request changes" radio button for my previous review.

Please ping me when all the changes are implemented.

@shenlebantongying
Copy link
Member Author

Thanks for the review. The things you mentioned are implemented. Much to learn! @drupol

:)

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks !

@drupol drupol merged commit 2fca7d4 into NixOS:master Aug 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: goldendict-ng
3 participants