-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goldendict-ng: init at 23.07.23 #244752
goldendict-ng: init at 23.07.23 #244752
Conversation
b8f2551
to
f757971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for your contribution.
I've left some comments, left me know if this is clear enough.
Also, remember that in the end, this PR should only contains 2 commits with very specific commit messages:
- 1 commit for adding you as maintainer:
maintainers: add slbtty
- 1 commit for the rest:
goldendict-ng: init at 23.07.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to select the "Request changes" radio button for my previous review.
Please ping me when all the changes are implemented.
f757971
to
fcb1923
Compare
fcb1923
to
4412cff
Compare
Thanks for the review. The things you mentioned are implemented. Much to learn! @drupol :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks !
Description of changes
Add new package https://github.com/xiaoyifang/goldendict-ng
close #239921
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)