-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lemurs: init at 0.3.1 #246287
lemurs: init at 0.3.1 #246287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for your contribution.
I've left some comments, left me know if this is clear enough.
owner = "coastalwhite"; | ||
repo = pname; | ||
rev = "v${version}"; | ||
sha256 = "sha256-6mNSLEWafw8yDGnemOhEiK8FTrBC+6+PuhlbOXTGmN0="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use hash
in place of sha256
.
This is optional since it could be automatized treewide at some point.
The idea is to avoid using sha256
as attribute and use hash
everywhere.
Since there could be different hashing algorithms in use, this make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks !
Please squash your commits so that this PR contains only 2 commits.
- 1 commit for adding you as maintainer
- 1 commit for the rest
03d903f
to
a07cee2
Compare
This should fix all aforementioned issues. Thanks for being patient! |
owner = "coastalwhite"; | ||
repo = pname; | ||
rev = "v${version}"; | ||
sha256 = "sha256-6mNSLEWafw8yDGnemOhEiK8FTrBC+6+PuhlbOXTGmN0="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not fixed.
applied editorconfig settings fix: lf line ending issue fix: repo can not be pname due to bind issues fix: use cargoHash not cargoSha256 lint: build inputs should new line lint: callPackage should have space in attrset
a07cee2
to
bc39d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Description of changes
Adds lemurs, a tty based display manager. I have tested it runs and accepts inputs.
This resolves #246035
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)