-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocaml-protoc-plugin: init at 4.3.1 #248155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you PR. I left a few comments mostly about style/metadata, but the package itself seems to build fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add yourself to the list in one commit, and then modify the package in one other. This is to ensure we can revert the commit affecting the package without breaking evaluation even if you add yourself as maintainer to other packages in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for your contribution.
I've left some comments, left me know if this is clear enough.
Moving this PR in draft until the feedback has been addressed, feel free to remove it from draft when it's done, so we can see it again appearing in our list of PRs to review. Thanks! |
Thanks for that, I'll address your feedbacks during the week :) |
142ec7d
to
93e1c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please ensure that your PR only contains 2 commits?
- 1 commit for adding you in the maintainers list:
maintainers: add GirardR1006
- 1 commit for the rest:
ocaml-protoc-plugin: init at 4.3.1
93e1c78
to
3af1968
Compare
3af1968
to
9fd6f2e
Compare
That should be it. Sorry for the force pushes, I believe they are making the review progress less trackable. Taking any advices on how to do that better for future contributions :) |
No worries for the force-pushed, it's mandatory here, and it's not considered as a bad practice as long as you stay in your branch, hopefully. At the moment, the CONTRIBUTING.md file is being rewritten, but you can already find some leads in there. For the rest, the commiters/maintainers are here to review and provide feedback. Feel free to ask anything, we'll be there to help. |
9fd6f2e
to
442472d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last minor thing and it's good to go for me.
442472d
to
bb810b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for implementing all the change requests!
Description of changes
Adding
ocaml-protoc-plugin
, an Ocaml library to convert Google protobuf format into Ocaml types.Project homepage: https://github.com/issuu/ocaml-protoc-plugin
I am not the original author, but I find this tool convenient enough to be added into nixpkgs. I will gladly be added as a maintainer for this package.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)