Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs.pkgs.color-theme-solarized: convert to melpaBuild #279472

Closed
wants to merge 2 commits into from
Closed

emacs.pkgs.color-theme-solarized: convert to melpaBuild #279472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acdd53c
emacs.pkgs.color-theme-solarized: convert to melpaBuild
AndersonTorres Jan 7, 2024
510bff9
emacs.pkgs.color-theme-solarized: remove samuelrivas from maintainers
AndersonTorres Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 33 additions & 18 deletions ...plications/editors/emacs/elisp-packages/manual-packages/color-theme-solarized/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,41 @@
{ lib
, trivialBuild
, fetchFromGitHub
, color-theme
, fetchFromGitHub
, melpaBuild
, writeText
}:

trivialBuild {
pname = "color-theme-solarized";
version = "0.pre+unstable=2017-10-24";
let
argset = {
pname = "color-theme-solarized";
ename = "color-theme-solarized";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ename defaults to pname

Suggested change
ename = "color-theme-solarized";

version = "20230209.837";

src = fetchFromGitHub {
owner = "sellout";
repo = "emacs-color-theme-solarized";
rev = "f3ca8902ea056fb8e46cb09f09c96294e31cd4ee";
hash = "sha256-oxX0lo6sxotEiR3nPrKPE9H01HKB3ohB/p8eEHFTp5k=";
};
src = fetchFromGitHub {
owner = "sellout";
repo = "emacs-color-theme-solarized";
rev = "b186e5d62d0b83cbf5cf38f7eb7a199dea9a3ee3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the bump and the melpaBuild conversion should be in two separate commits.

hash = "sha256-7E8r56dzfD06tsQEnqU5mWSbwz9x9QPbzken2J/fhlg=";
};

packageRequires = [
color-theme
];
Comment on lines +20 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed since sellout/emacs-color-theme-solarized@30dfe48.

Suggested change
packageRequires = [
color-theme
];


commit = argset.src.rev;

packageRequires = [ color-theme ];
recipe = writeText "recipe" ''
(color-theme-solarized
:repo "sellout/emacs-color-theme-solarized"
:fetcher github)
'';

meta = with lib; {
homepage = "http://ethanschoonover.com/solarized";
description = "Precision colors for machines and people; Emacs implementation";
license = licenses.mit;
maintainers = with maintainers; [ samuelrivas AndersonTorres ];
meta = {
homepage = "http://ethanschoonover.com/solarized";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the home page for this package. It's the home page for the Solarized theme.

And please use https.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe HTTPS link fails sometimes. But OK, I will quote the GitHub link.

description = "Precision colors for machines and people; Emacs implementation";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ AndersonTorres ];
};
};
}
in
melpaBuild argset