Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gns3-server: fix ubridge_path #292095

Closed

Conversation

dani0854
Copy link
Contributor

Description of changes

Ubridge doesn't work since the path passed to gns3-server is to the nix store version rather than security wrapper created just before. This PR fixes this

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dani0854
Copy link
Contributor Author

Now I get:

Could not determine uBridge version for /run/wrappers/bin/ubridge

I guess it has something to do with permissions. But since there is no logging in the gns3server for this part, I would probably need to patch the gns3-server package to get that message.

I have tried adding o=rx to security wrapper, but that didn't fix the problem. And since it runs fine when launched as normal user with docker and ubridge groups, I suspect it has something to do with systemd service config.

@dani0854
Copy link
Contributor Author

Created an issue for further discussion #292258

@dani0854
Copy link
Contributor Author

Closing in favour of #303442

@dani0854 dani0854 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant