Add openfga package #294367
Open
Add openfga package #294367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolbinarycat
reviewed
Mar 8, 2024
sikmir
reviewed
Mar 10, 2024
sikmir
reviewed
Mar 10, 2024
Co-authored-by: lolbinarycat <[email protected]>
…ildPhase Co-authored-by: Nikolay Korotkiy <[email protected]>
|
Thanks for taking your time to review my PR! I've applied your suggestions. |
lolbinarycat
approved these changes
Mar 14, 2024
|
@lolbinarycat I just realised there were a couple of PRs opened over recent weeks for adding openfga (#295024, #297676) @lucperkins, @gaelreyrol I guess we should pick one? |
|
#297676 seems the most complete to me |
|
It seems there's been another PR merged in the meantime: #310534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add openfga to Nix packages repository. Will resolve openfga/openfga#1048
It's my first time contributing to the nixpkgs repository, so I've added myself as a maintainer too. Let me know if I've missed anything. One question I have is - should I force the output of
go buildcommand to be in./result/bin/directory? Currently resulting bin ends up in./result.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.