Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldap-cli: init at 0-unstable-2024-05-15 #304721

Closed
wants to merge 1 commit into from

Conversation

ibizaman
Copy link
Contributor

Description of changes

New package https://github.com/Zepmann/lldap-cli

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
@ibizaman ibizaman requested a review from pluiedev May 22, 2024 04:59
@ibizaman
Copy link
Contributor Author

ibizaman commented Jun 3, 2024

Friendly ping just in case you didn't see the update @pluiedev

@Aleksanaa Aleksanaa changed the title lldap-cli: init at commit d1fe500 lldap-cli: init at 0-unstable-2024-05-15 Jun 20, 2024
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 2 minor comments, and I will need you to pass your new file through nixfmt-rfc-style.

pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/lldap-cli/package.nix Outdated Show resolved Hide resolved
@ibizaman ibizaman force-pushed the lldap-cli branch 3 times, most recently from 4adda16 to 55ecc60 Compare July 10, 2024 06:54
@ibizaman
Copy link
Contributor Author

@drupol I answered all review comments.
Also, I passed the file through the formatter, it changed the import comma style.

@ibizaman ibizaman requested a review from drupol July 10, 2024 10:09
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit log message should be the same as the PR title.

Also, there's a merge conflict...

@alyssais
Copy link
Member

alyssais commented Aug 6, 2024

#326131

@alyssais alyssais closed this Aug 6, 2024
@ibizaman ibizaman deleted the lldap-cli branch August 18, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants