-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuda-modules: fixed output derivations and new modules #306172
Draft
ConnorBaker
wants to merge
71
commits into
NixOS:master
Choose a base branch
from
ConnorBaker:feat/cudaPackages-fixed-output-derivations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
cuda-modules: fixed output derivations and new modules #306172
ConnorBaker
wants to merge
71
commits into
NixOS:master
from
ConnorBaker:feat/cudaPackages-fixed-output-derivations
+51,517
−29,284
Commits on Sep 13, 2024
-
cudaPackages.cudatoolkit: 12.3.0 -> 12.3.2; init 12.4.1 cudaPackages.cudnn: update for 9.x cudaPackages.cuda_cudart: remove stubs workaround python3Packages.openai-triton: update substituteInPlace and cudaPackages outputs individual allowFHSReferences, don't use getOutput, refactor setupCudaHook fixups fixup fixup switch back to cudaFlags; various simplifications fixup eval errors remove extra whitespace fixups fixup fixup fixups fixups fixups fixups fixups fixups fixups fixups fixups fixups fixups fixups fixup fixup fixup mapAttrs mkOption to avoid forgetting to apply it to an argument alphabetize Add latest from cuda-redist-find-features; must update to reflect nesting of index in data.indices update for data.indices and file shuffle wip wip brain hurt ;( CUDA packages should be visible on all platforms, but not necessarily buildable switch to utils.mkMissingPackagesBrokenConditions pattern to avoid missing attribute errors cudaPackages now evaluates deeply wip wip wip use lazyAttrsOf to avoid strictly evaluating during checks wip overrideAttrs doesn't deeply merge attribute sets fix missing src for cudnn_samples cudnn_samples: mark as broken for now cudaPackages: add major versions to avoid need sort and filter packages cudaPackages.cudnn: fix selection logic (was not using result of filterAttrs) cudaPackages.cuquantum: fixup cudaPackages.nccl: broken on CUDA pre-11.4 due to API changes cudaPackages: add note about recurseIntoAttrs and nixpkgs-review cudaPackages: temporarily add recurseIntoAttrs on all package sets cudaPackages.utils: fix usages of mkMissingPackagesBrokenConditions cudaPackages.tensorrt: use cudatoolkit prior to CUDA 11.4 cudaPackages: set name expressly to make clear where packages originate cudaPackages.cudnn: requires CUDA 10.1 or later cudaPackages.libnvvm_samples: allow FHS references cudaPackages.nsight_compute: fix cudaPackages.libcal: correct dependency on ucc cudaPackages.libcublasmp: correct selection logic cudaPackages: deep overriding of pkgs cudaPackages: re-add reference to self to fix package selection Prior to this change, packages like CUDNN would take the newest version of packages like cudatoolkit (which is to say packages created through packagesFromDirectoryRecursive). That is, cudaPackages_11_0.cudnn_8_5.buildInputs would reference cudaPackages.cudatoolkit rather than cudatoolkit from the same cudaPackages. !fixup 3724a77 wip cudaPackages.setupCudaHook: wip cudaPackages_12_5: fixes cudaPackages.cudnn_samples: require cudnn be available cudaPackages: guard invalid eval behind badPlatforms cudaPackages.tensorrt: don't rely on passthru for buildInputs While this may complicate overriding the package, it does resolve an infinite recursion error. cudaPackages: create dummy outputs to avoid missing attribute errors cudaPackages.libcusparse_lt: add overrides and constraints cudaPackages.tensorrt: handle constraints for unsupported architectures cudaPackages.cuda_compat: allow FHS references cudaPackages: fix src selection logic TODO: update cudaPackages: enable override and implement per-output overrides cudaPackages: add setup hook for cuda_cudart.stubs to add to NIX_LDFLAGS cudaPackages.cuda_cudart.stubs: set LD_LIBRARY_PATH in setup hook cudaPackages: move setup-cuda-stubs-hook to manifest-builder wip fixup after rebase on 2024-07-10 regen JSON as of cuda-redist-find-features@239ee25f2ed08a27e24762be384361d17b8911b8
Configuration menu - View commit details
-
Copy full SHA for edbab0a - Browse repository at this point
Copy the full SHA edbab0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3cbcbe - Browse repository at this point
Copy the full SHA f3cbcbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6324a9c - Browse repository at this point
Copy the full SHA 6324a9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9685e79 - Browse repository at this point
Copy the full SHA 9685e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9fd1f0 - Browse repository at this point
Copy the full SHA e9fd1f0View commit details -
Thanks to the work of SomeoneSerge, the lib.get* family of output selectors now work! In order to keep closure sizes small, the `dev` output propagates only `bin`, `include`, and `lib` outputs. The `include` output is new -- it is the `include` directory, and was separated out from the `dev` output to allow for more granular dependencies between derivations. As an example, cuda_cudart.include depends on cuda_nvcc.include and cuda_cccl.include, but adding a dependency on the dev output of either would greatly increase the size of the closure relative to the tiny header files. Since `dev` is the default output selected by `make-derivation.nix`, in general the `lib.get*` family of functions should only be necessary for retrieving an output which contains a specific directory. This happens frequently when trying to slim down a closure (retrieving only the `include` output) or because you need the full path to a directory (e.g., `(lib.getLib cuda_cudart) + "/lib"`).
Configuration menu - View commit details
-
Copy full SHA for b1491ee - Browse repository at this point
Copy the full SHA b1491eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8c4f83 - Browse repository at this point
Copy the full SHA a8c4f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for de425e3 - Browse repository at this point
Copy the full SHA de425e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e005a4a - Browse repository at this point
Copy the full SHA e005a4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3121a - Browse repository at this point
Copy the full SHA 2f3121aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6827d97 - Browse repository at this point
Copy the full SHA 6827d97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 629cfa8 - Browse repository at this point
Copy the full SHA 629cfa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c2947 - Browse repository at this point
Copy the full SHA 12c2947View commit details -
Configuration menu - View commit details
-
Copy full SHA for 950c598 - Browse repository at this point
Copy the full SHA 950c598View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06e79ad - Browse repository at this point
Copy the full SHA 06e79adView commit details -
Configuration menu - View commit details
-
Copy full SHA for d382732 - Browse repository at this point
Copy the full SHA d382732View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aa1551 - Browse repository at this point
Copy the full SHA 9aa1551View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed2db1 - Browse repository at this point
Copy the full SHA 8ed2db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42176a0 - Browse repository at this point
Copy the full SHA 42176a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a9003c - Browse repository at this point
Copy the full SHA 2a9003cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4edf375 - Browse repository at this point
Copy the full SHA 4edf375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e92310 - Browse repository at this point
Copy the full SHA 8e92310View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca49ec - Browse repository at this point
Copy the full SHA bca49ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69920b6 - Browse repository at this point
Copy the full SHA 69920b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff6bbe8 - Browse repository at this point
Copy the full SHA ff6bbe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd76175 - Browse repository at this point
Copy the full SHA fd76175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4156506 - Browse repository at this point
Copy the full SHA 4156506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dc3b4d - Browse repository at this point
Copy the full SHA 8dc3b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a7363d - Browse repository at this point
Copy the full SHA 9a7363dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba603ab - Browse repository at this point
Copy the full SHA ba603abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a3e6a5 - Browse repository at this point
Copy the full SHA 1a3e6a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 190f814 - Browse repository at this point
Copy the full SHA 190f814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1edc98f - Browse repository at this point
Copy the full SHA 1edc98fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3318a6d - Browse repository at this point
Copy the full SHA 3318a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a04920 - Browse repository at this point
Copy the full SHA 5a04920View commit details -
Configuration menu - View commit details
-
Copy full SHA for da21148 - Browse repository at this point
Copy the full SHA da21148View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec18ac - Browse repository at this point
Copy the full SHA 8ec18acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8213595 - Browse repository at this point
Copy the full SHA 8213595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cc9c4f - Browse repository at this point
Copy the full SHA 5cc9c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c50a6a - Browse repository at this point
Copy the full SHA 4c50a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf8b1c1 - Browse repository at this point
Copy the full SHA cf8b1c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e489a8f - Browse repository at this point
Copy the full SHA e489a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0ba5b - Browse repository at this point
Copy the full SHA cd0ba5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 255347e - Browse repository at this point
Copy the full SHA 255347eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1b6078 - Browse repository at this point
Copy the full SHA a1b6078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f4838 - Browse repository at this point
Copy the full SHA 26f4838View commit details -
openai-whisper-cpp: CUDA fixups
`cuda_cccl.dev` is now propagated by `cuda_cudart.dev`, which is provided by `cuda_cudart`.
Configuration menu - View commit details
-
Copy full SHA for 671992f - Browse repository at this point
Copy the full SHA 671992fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e994eeb - Browse repository at this point
Copy the full SHA e994eebView commit details -
waifu2x-converter-cpp: CUDA fixups
`opencv.cxxdev` provides all necessary CUDA utilities for this package.
Configuration menu - View commit details
-
Copy full SHA for 4ae3fec - Browse repository at this point
Copy the full SHA 4ae3fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5489190 - Browse repository at this point
Copy the full SHA 5489190View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fd6d0 - Browse repository at this point
Copy the full SHA c4fd6d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2382f7 - Browse repository at this point
Copy the full SHA e2382f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0296b5 - Browse repository at this point
Copy the full SHA c0296b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 144e2b5 - Browse repository at this point
Copy the full SHA 144e2b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a87278a - Browse repository at this point
Copy the full SHA a87278aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d4073 - Browse repository at this point
Copy the full SHA 26d4073View commit details -
Configuration menu - View commit details
-
Copy full SHA for a002044 - Browse repository at this point
Copy the full SHA a002044View commit details -
Configuration menu - View commit details
-
Copy full SHA for e750f6a - Browse repository at this point
Copy the full SHA e750f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d91912 - Browse repository at this point
Copy the full SHA 3d91912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ecf02a - Browse repository at this point
Copy the full SHA 1ecf02aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0afd714 - Browse repository at this point
Copy the full SHA 0afd714View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b2ee44 - Browse repository at this point
Copy the full SHA 7b2ee44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d6eb2f - Browse repository at this point
Copy the full SHA 4d6eb2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1016b95 - Browse repository at this point
Copy the full SHA 1016b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 560dd49 - Browse repository at this point
Copy the full SHA 560dd49View commit details -
Configuration menu - View commit details
-
Copy full SHA for a731888 - Browse repository at this point
Copy the full SHA a731888View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad7e17f - Browse repository at this point
Copy the full SHA ad7e17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for da17174 - Browse repository at this point
Copy the full SHA da17174View commit details -
Configuration menu - View commit details
-
Copy full SHA for fed9d55 - Browse repository at this point
Copy the full SHA fed9d55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62796e8 - Browse repository at this point
Copy the full SHA 62796e8View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 71ebe67 - Browse repository at this point
Copy the full SHA 71ebe67View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.