Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdemu: updates, fixes and build simplification #311780

Merged
merged 4 commits into from
May 15, 2024
Merged

cdemu: updates, fixes and build simplification #311780

merged 4 commits into from
May 15, 2024

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented May 14, 2024

Description of changes

  • rely on wrapGApps*Hook for gobject-introspection access
  • use callPackage as intended

fix #311690

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@keenanweaver
Copy link
Member

Result of nixpkgs-review pr 311780 run on x86_64-linux 1

5 packages built:
  • cdemu-client
  • cdemu-daemon
  • gcdemu
  • image-analyzer
  • libmirage

keenanweaver
keenanweaver approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue! Thank you!

jtojnar
jtojnar reviewed May 15, 2024
View reviewed changes
pkgs/applications/emulators/cdemu/base.nix Show resolved Hide resolved
pkgs/applications/emulators/cdemu/base.nix Outdated Show resolved Hide resolved
pkgs/applications/emulators/cdemu/analyzer.nix Show resolved Hide resolved
pkgs/applications/emulators/cdemu/analyzer.nix Outdated Show resolved Hide resolved
pkgs/applications/emulators/cdemu/base.nix Outdated Show resolved Hide resolved
@jtojnar jtojnar mentioned this pull request May 15, 2024
Open
@bendlas
cdemu: updates, fixes and build simplification
16d85ec 
- rely on wrapGApps*Hook for gobject-introspection access
- use callPackage as intended
@bendlas
cdemu: use hash instead of sha256
d495624
@bendlas
cdemu: use standard cmake build hook
e58724d
@bendlas bendlas merged commit 147760c into NixOS:master May 15, 2024
20 checks passed
@bendlas
Copy link
Contributor Author

bendlas commented May 15, 2024

still not able to use buildPythonApplication because of #311780 (comment), but this is good enough for now.

@bendlas bendlas mentioned this pull request May 15, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@keenanweaver keenanweaver keenanweaver approved these changes

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdemu: not mounting images
3 participants
@bendlas @keenanweaver @jtojnar