birdtray: fix PATH handling, move to by-name

[eclairevoyant]

Description of changes

• birdtray: move to by-name
• birdtray: fix PATH handling
  • fixes Birdtray hard codes a default path #291745
  • allows using thunderbird as the setting for the thunderbird binary, which will allow searching PATH for the binary
  • also wraps birdtray with thunderbird

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[drupol]

I'll let someone else validate it.

I don't agree so much on touching files and not improving them and postpone that in another PR.

Hope you understand that this is not against you @eclairevoyant personally !

[eclairevoyant]

Sure, I get it. Re: pname use, I just don't like re-explaining / re-justifying the same arguments in multiple PRs to everyone who might disagree, and I'd rather have all the discussion about pname use in one place.

As for reformatting, I don't have a strong opinion either way, but folks such as @SuperSandro2000 apparently do. In any case I consider it busy work to have to keep adding entries to the .git-blame-ignore-revs, and have to keep updating it if I rebase the commits, etc. Unless we are reformatting an entire package set or something the effort doesn't seem worth it to me. It's also not enforced outside of certain paths that are already tracked in the CI (which would result in a CI fail).

I moved to by-name since that's not really automatable and (save for one person) I've basically never seen an objection to it. It also makes future changes easier.

[eclairevoyant]

Closing as per #291745 (comment), this may still be the wrong approach.