git-gamble: init at 2.9.0 #332592
git-gamble: init at 2.9.0 #332592
Conversation
pinage404
force-pushed
the
git-gamble-init
branch
from
6235ad9
to
bcb5025
Compare
pinage404
force-pushed
the
git-gamble-init
branch
from
bcb5025
to
a9c4363
Compare
|
Result of 1 package built:
|
There was a problem hiding this comment.
Thanks for pinging me on this, @pinage404.
IMO this PR should only contain commits related to adding the initial version of the git-gamble package.
Apart from that please find below a few more suggestions for improvement.
There was a problem hiding this comment.
Thanks for pinging me on this, @pinage404.
IMO this PR should only contain commits related to adding the initial version of the git-gamble package.
Apart from that please find below a few more suggestions for improvement.
pinage404
force-pushed
the
git-gamble-init
branch
2 times, most recently
from
e87edc3
to
4cb4516
Compare
|
When a package already have a What is the recommended way of packaging ? Do there is a way to reuse the flake output in |
Not without import-from-derivation (IFD) which is disallowed in nixpkgs. |
| ]; | ||
| postInstall = '' | ||
| wrapProgram $out/bin/git-gamble \ | ||
| --prefix PATH : "${lib.makeBinPath [ git ]}" |
There was a problem hiding this comment.
i wonder which is better between git and gitMinimal ?
There was a problem hiding this comment.
Looking at the package definition of gitMinimal I'd say it's a good choice to use here, unless git-gamble requires support for python, perl or pcre2 in git…
There was a problem hiding this comment.
Done !
Thanks for the quick response !
Why is it disallowed ? |
pinage404
force-pushed
the
git-gamble-init
branch
from
4cb4516
to
59cd5ef
Compare
|
Import From Derivation (IFD) is disallowed in Nixpkgs for performance reasons. |
|
Result of 1 package built:
|
|
Thank you for providing insightful context, @pbsds, very helpful and much appreciated 👍 |
|
It seems weird to me that flake are not well integrated into the nix build ecosystem Thanks for the explanations =D |
Description of changes
I updated / improved some packages i maintain, theni added a package, if i have to split, just tell me =)Tool that blends TDD (Test Driven Development) + TCR (
test && commit || revert) to make sure to develop the right thing 😌, baby step by baby step 👶🦶https://git-gamble.is-cool.dev/
When a package already have a
flake.nixwhich exposepackages.<system>.<package-name>, what is the recommended way of packaging ? Do there is a way to reuse the flake output innixpkgs?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.